Skip to content

fix: cap websocket message buffering and remove stale websocket entries #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CypherPotato merged 1 commit into from
May 25, 2026
Merged

fix: cap websocket message buffering and remove stale websocket entries #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Http/Streams/HttpWebSocket.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,9 @@ internal HttpWebSocket ( HttpServerEngineWebSocket ctx, HttpRequest req, string?
private async ValueTask<WebSocketMessage?> ReceiveInternalAsync ( CancellationToken cancellation ) {
ArraySegment<byte> buffer = new ArraySegment<byte> ( receiveBuffer );
ValueWebSocketReceiveResult result;
long maxMessageLength = request.baseServer.ServerConfiguration.MaximumContentLength <= 0
? Int32.MaxValue
: request.baseServer.ServerConfiguration.MaximumContentLength;

if (IsClosed)
return null;
Expand All @@ -137,6 +140,11 @@ internal HttpWebSocket ( HttpServerEngineWebSocket ctx, HttpRequest req, string?

do {
result = await ctx.ReceiveAsync ( buffer, cancellation );
if ((ms.Length + result.Count) > maxMessageLength) {
await ctx.CloseOutputAsync ( WebSocketCloseStatus.MessageTooBig, null, cancellation );
await CloseAsync ( cancellation );
return null;
}
ms.Write ( buffer.Array!, buffer.Offset, result.Count );
} while (!result.EndOfMessage);

Expand Down
6 changes: 5 additions & 1 deletion src/Http/Streams/HttpWebSocketConnectionCollection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ internal void RegisterWebSocket ( HttpWebSocket src ) {
// close another websockets with same identifier
HttpWebSocket [] wsId = Find ( s => s == src._identifier );
foreach (HttpWebSocket ws in wsId) {
_ws.Remove ( ws );
ws.Dispose ();
}
_ws.Add ( src );
Expand Down Expand Up @@ -96,7 +97,10 @@ public HttpWebSocket [] All () {
/// </summary>
public void DropAll () {
lock (_ws) {
foreach (HttpWebSocket es in _ws)
HttpWebSocket [] allWs = _ws.ToArray ();
_ws.Clear ();

foreach (HttpWebSocket es in allWs)
es.Dispose ();
}
}
Expand Down
Loading