fix: harden docker deployment defaults#3897
Draft
bbingz wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a smaller Docker-only slice split out of the broader security hardening draft PR (#3895).
Changes:
nginxValidation run locally:
docker build --target final -t sscms-root-docker-split-check .-> passed; current master dependency warning for HtmlSanitizer is still present because this PR intentionally does not include dependency updatesdocker build -f docker/Dockerfile.core -t sscms-core-docker-split-check docker-> passeddocker build -f docker/Dockerfile.nginx -t sscms-nginx-docker-split-check docker-> passeddocker compose -f docker/mysql/docker-compose.yml configwith placeholder env -> passeddocker compose -f docker/postgres/docker-compose.yml configwith placeholder env -> passeddocker compose -f docker/cluster/docker-compose.yml configwith placeholder env -> passeddocker run --rm --add-host sscms:127.0.0.1 sscms-nginx-docker-split-check nginx -t-> passedtrivy config --severity UNKNOWN,LOW,MEDIUM,HIGH,CRITICAL --format table .-> 0 Dockerfile misconfigurations