Add h1-case-adjust-bogus-server option - #225
Open
kenichi-mashiyama wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for the
option h1-case-adjust-bogus-serverdirective in thedefaultssection of the HAProxy configuration.Motivation
Currently, there is no way to configure
h1-case-adjust-bogus-serverin the defaults section through the HAProxy Operator CRDs. This option is necessary for environments dealing with legacy or non-compliant backend servers that require strict HTTP/1.1 header casing (e.g., expectingContent-Typeinstead ofcontent-type). By adding this boolean field, users can now easily enable this feature globally via theDefaultsConfiguration.Changes
H1CaseAdjustBogusServerboolean field to theDefaultsConfigurationstruct inapis/proxy/v1alpha1/instance_types.go.Model()method for the defaults configuration to map this new field to the native HAProxy model (models.DefaultsBaseH1CaseAdjustBogusServerEnabled).apis/proxy/v1alpha1/instance_types_test.goto verify the correct generation of theoption h1-case-adjust-bogus-serverdirective when enabled, and its absence when disabled.Checklist