feat: add enchanting/experimentation data#61
Open
tonydawhale wants to merge 1 commit into
Open
Conversation
Added lodash package to deep copy. If we can think of another solution, I am down to implement that instead.
Contributor
|
The built-in |
Contributor
Author
I believe we're using lodash in another PR (#60) so I think might end up just keeping. |
ptlthg
requested changes
Jan 10, 2024
| return { | ||
| unlocked: !!userProfile.experimentation, | ||
| experiments: userProfile.experimentation | ||
| ? Object.fromEntries( |
Contributor
There was a problem hiding this comment.
This whole Object.fromEntries(...) call should be separated into a new function, it's doing way too much to be inlined like this. I know we're kinda doing the same thing elsewhere already, but we should probably be more strict with things like this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added lodash package to deep copy. If we can think of another solution, I am down to implement that instead.