docs: clarify slack_read_thread uses message_ts not thread_ts - #101
Draft
WilliamBergamin wants to merge 2 commits into
Draft
docs: clarify slack_read_thread uses message_ts not thread_ts#101WilliamBergamin wants to merge 2 commits into
WilliamBergamin wants to merge 2 commits into
Conversation
Search permalinks surface the thread timestamp as ?thread_ts=<ts>, but slack_read_thread expects it under message_ts. LLM agents pattern-match thread_ts from search output, the call is rejected, and they retry — costing latency and tokens each time (issue #57). Document the correct parameter name in the slack-search skill (Following Up on Results + Common Pitfalls) and in the find-discussions, standup, and summarize-channel commands that call slack_read_thread directly. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
🦋 Changeset detectedLatest commit: 4f968b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request documents that
slack_read_threadtakes the thread timestamp undermessage_ts, notthread_ts, to eliminate a recurring failed-call-and-retry cycle.slack_read_threadparameter namedmessage_tsinstead ofthread_ts#57.?thread_ts=<ts>, so LLM agents pattern-matchthread_tsand callslack_read_threadwith the wrong parameter name; the server rejects it and the agent retries withmessage_ts, costing ~750ms plus tokens each time.thread_tsas an alias) lives in the closed-source MCP server and is tracked internally; this PR addresses the experience from the open-source side.slack-searchskill in two spots: the Following Up on Results bullet and a new Common Pitfalls entry.message_ts-not-thread_tsreminder to thefind-discussions,standup, andsummarize-channelcommands, which callslack_read_threaddirectly.slackpatch changeset.Preview
N/A — documentation-only change (skill and command prompt text).
Testing
skills/slack-search/SKILL.mdand the three command prompts and confirm each namesmessage_tsas the correct parameter and ties it to the?thread_ts=permalink value.slack_search_public_and_private, take a result permalink'sthread_tsvalue, and confirmslack_read_thread { channel_id, message_ts }succeeds on the first call.Notes
Intentionally does not add an eval scenario:
tests/eval/test_tool_selection.pyonly validates which tool the model selects, not parameter values, so it cannot exercise this fix.Verified locally with
make lintandmake test-unit(both pass). The eval layer ofmake testwas not run locally as it needsGEMINI_API_KEY/SLACK_MCP_TOKEN; CI runs it.Requirements
make testand the tests pass.