Skip to content

feat: Add optional fastBurn/slowBurn aliases for page and ticket alerts - #843

Open
cxdy wants to merge 1 commit into
slok:mainfrom
cxdy:cxdy/high-low-alert-aliases
Open

feat: Add optional fastBurn/slowBurn aliases for page and ticket alerts#843
cxdy wants to merge 1 commit into
slok:mainfrom
cxdy:cxdy/high-low-alert-aliases

Conversation

@cxdy

@cxdy cxdy commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Closes #833

Accept fast_burn/slow_burn as non-breaking aliases of page_alert/ticket_alert and the CRD pageAlert/ticketAlert keys. Old names still work; setting both for one class is an error. Generated rules stay page/ticket.

@codecov-commenter

codecov-commenter commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 73.46939% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 31.70%. Comparing base (8a3be4f) to head (80b6dfd).

Files with missing lines Patch % Lines
pkg/kubernetes/api/sloth/v1/alerting.go 77.77% 4 Missing and 4 partials ⚠️
pkg/prometheus/api/v1/alerting.go 77.77% 4 Missing and 4 partials ⚠️
internal/storage/io/k8s_sloth.go 66.66% 2 Missing and 2 partials ⚠️
internal/storage/io/sloth.go 66.66% 2 Missing and 2 partials ⚠️
...g/kubernetes/api/sloth/v1/zz_generated.deepcopy.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #843      +/-   ##
==========================================
+ Coverage   31.30%   31.70%   +0.39%     
==========================================
  Files         149      151       +2     
  Lines        9228     9314      +86     
==========================================
+ Hits         2889     2953      +64     
- Misses       6088     6100      +12     
- Partials      251      261      +10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cxdy
cxdy force-pushed the cxdy/high-low-alert-aliases branch from d33e81b to 2e55454 Compare September 8, 2026 00:49
@cxdy
cxdy marked this pull request as ready for review September 8, 2026 00:53
@cxdy
cxdy requested a review from slok as a code owner September 8, 2026 00:53
@wbollock

wbollock commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

I prefer fast_burn and slow_burn compared to high and low. high and low makes it feel like they are related to severities or urgency rather than burn rate

@cxdy cxdy changed the title feat: Add optional high/low aliases for page and ticket alerts feat: Add optional fastBurn/slowBurn aliases for page and ticket alerts Sep 14, 2026
Accept fast_burn/slow_burn as non-breaking aliases of page_alert/ticket_alert
and the CRD pageAlert/ticketAlert keys. Old names still work; setting
both for one class is an error. Generated rules stay page/ticket.

Signed-off-by: Cody Kaczynski <ckaczyns@akamai.com>
@cxdy
cxdy force-pushed the cxdy/high-low-alert-aliases branch from 5eb3832 to 80b6dfd Compare September 14, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Have optional new naming for page and ticket alert options

3 participants