Conversation
Sloth 0.12 codebase used
Added duplicates check See merge request sre/sloth!1
Add gitlab-ci.yml See merge request sre/sloth!2
Closes slok#804 Signed-off-by: Dmitriy S. Sinyavskiy <contact@r3code.ru>
Fix: denominator_corrected_rules/v1 invalid result for complex queries See merge request sre/sloth!3
…фика после простоя На сервисах с исторически низким или отсутствующим трафиком, которые внезапно начинали получать нагрузку, расчёт SLI выдавал отрицательные значения (на практике зафиксировано ~ -52000%). Причина: плагин denominator_corrected_rules_v1 рассчитывает корректирующий множитель как k = rate(5m) / rate(30d). При rate_30d ≈ 0.0001 req/s и всплеске до rate_5m ≈ 1.0 req/s значение k взлетало до ~10000, что приводило к переполнению формулы SLI (1 - k * bad/total).
fix: исправлены абсурдные отрицательные значения SLI при всплеске трафика после простоя See merge request sre/sloth!4
Closes slok#804 Signed-off-by: Dmitriy S. Sinyavskiy <contact@r3code.ru>
…фика после простоя На сервисах с исторически низким или отсутствующим трафиком, которые внезапно начинали получать нагрузку, расчёт SLI выдавал отрицательные значения (на практике зафиксировано ~ -52000%). Причина: плагин denominator_corrected_rules_v1 рассчитывает корректирующий множитель как k = rate(5m) / rate(30d). При rate_30d ≈ 0.0001 req/s и всплеске до rate_5m ≈ 1.0 req/s значение k взлетало до ~10000, что приводило к переполнению формулы SLI (1 - k * bad/total).
# Conflicts: # .gitlab-ci.yml
Подтянуты изменения из sloth.dev v0.16.0 + main See merge request sre/sloth!5
# Conflicts: # internal/plugin/slo/contrib/denominator_corrected_rules_v1/plugin_test.go
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #844 +/- ##
==========================================
+ Coverage 30.84% 31.30% +0.46%
==========================================
Files 141 149 +8
Lines 8689 9228 +539
==========================================
+ Hits 2680 2889 +209
- Misses 5770 6088 +318
- Partials 239 251 +12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.