Skip to content

Fix denominator-corrected-rules plugin issues (complex query, numerator overflow) - #845

Closed
r3code wants to merge 2 commits into
slok:mainfrom
vseinstrumentiru:main
Closed

r3code wants to merge 2 commits into
slok:mainfrom
vseinstrumentiru:main

Conversation

@r3code

@r3code r3code commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

See #804 and #842

r3code added 2 commits March 16, 2026 18:45
Sloth 0.12 codebase used
#9)

Closes slok#804

Signed-off-by: Dmitriy S. Sinyavskiy <contact@r3code.ru>
@r3code
r3code requested a review from slok as a code owner September 8, 2026 10:21
@r3code r3code closed this Sep 8, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 31.30%. Comparing base (3757b66) to head (d4869ff).
⚠️ Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
cmd/sloth/commands/validate.go 0.00% 15 Missing ⚠️
...o/contrib/denominator_corrected_rules_v1/plugin.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #845      +/-   ##
==========================================
+ Coverage   30.84%   31.30%   +0.46%     
==========================================
  Files         141      149       +8     
  Lines        8689     9228     +539     
==========================================
+ Hits         2680     2889     +209     
- Misses       5770     6088     +318     
- Partials      239      251      +12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants