fix(storage): repair the retention test build after GetRecentSessions gained a status filter - #939
Merged
Conversation
… gained a status filter Semantic merge conflict, not a logic bug: #928 added sessions_retention_test.go calling GetRecentSessions(limit) while #930 added a status parameter for the tray glance's client filtering. Both PRs were green independently and broke main only once combined, because branch protection does not require a PR to be up to date with main before merging. Pass "" — the documented no-filter value — at the four call sites. The retention tests want every surviving record, so unfiltered is the correct argument, not merely the compiling one.
Deploying mcpproxy-docs with
|
| Latest commit: |
89f7e9e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4de73aaa.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-session-retention-test-b.mcpproxy-docs.pages.dev |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main is currently red —
internal/storagefails to build, which failed thev0.53.0-rc.1prerelease build at the qa-gate step.Cause
A semantic merge conflict between two PRs that were each green on their own:
internal/storage/sessions_retention_test.go, callingGetRecentSessions(limit)status stringparameter toGetRecentSessionsfor the tray glance's client filteringNeither PR was required to be up to date with main before merging (
strict=falseon branch protection), so the combination was never built until it landed.(and the same at :252, :278, :300)
Fix
Pass
""at the four call sites. That is the documented no-filter value — the retention tests want to count every surviving record, so unfiltered is the semantically correct argument rather than just the one that compiles.Verification
go build ./...,go vet ./internal/storage/, andgo test -race ./internal/storage/all pass locally.Once this lands I will re-cut the release candidate.