beholder: log partial delivery per-event errors with error_code and reason#2210
Draft
pkcll wants to merge 3 commits into
Draft
beholder: log partial delivery per-event errors with error_code and reason#2210pkcll wants to merge 3 commits into
pkcll wants to merge 3 commits into
Conversation
4 tasks
Contributor
📊 API Diff Results
|
pkcll
force-pushed
the
chipingress-partial-delivery-cl-nodes
branch
3 times, most recently
from
bcb946f to
59011ac
Compare
…code label - Type-assert send callback error to *batch.PublishError; log at WARN with error_code, reason, domain, entity for per-event server rejections. - Add error_code label to chip_ingress.events_dropped metric so dashboards and alerts can distinguish rejection types without relying on logs. - Whole-batch RPC failures keep the existing ERROR log; their drop metric omits error_code (no structured server code available). - Also adds failure_type label (partial_delivery / rpc_error) to the dropped counter to distinguish the two failure modes. Jira: INFOPLAT-13901
pkcll
force-pushed
the
chipingress-partial-delivery-cl-nodes
branch
from
59011ac to
d16297c
Compare
- Add batch.ClassifyDropFailure for partial_delivery, rpc_error, buffer_full, and client_error paths with shared metric dimensions. - Replace failure_type/grpc_code labels with error_type and error_code (PUBLISH_ERROR_CODE_* or gRPC code name) plus error_reason. - Add ErrMessageBufferFull and ErrClientShutdown sentinels for queue drops. Jira: INFOPLAT-13901
Contributor
✅ API Diff Results -
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Jira: INFOPLAT-13901 | Epic: INFOPLAT-7177
Must merge before the chainlink PR that bumps this dep.
Changes
Test plan