Skip to content

Remove high cardinality event_id from metrics#2247

Merged
DylanTinianov merged 3 commits into
mainfrom
base-trigger-metrics-fix
Jul 14, 2026
Merged

Remove high cardinality event_id from metrics#2247
DylanTinianov merged 3 commits into
mainfrom
base-trigger-metrics-fix

Conversation

@DylanTinianov

Copy link
Copy Markdown
Contributor

Requires

Supports

@DylanTinianov DylanTinianov self-assigned this Jul 13, 2026
@DylanTinianov DylanTinianov marked this pull request as ready for review July 13, 2026 18:07
@DylanTinianov DylanTinianov requested a review from a team as a code owner July 13, 2026 18:07
@DylanTinianov DylanTinianov requested review from patrickhuie19 and pkcll and removed request for ilija42 July 13, 2026 18:10
@DylanTinianov DylanTinianov enabled auto-merge July 13, 2026 18:18
@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

⚠️ API Diff Results - github.com/smartcontractkit/chainlink-common

⚠️ Breaking Changes (8)

pkg/capabilities.(*BaseTriggerBeholderMetrics) (4)
  • IncAck — Type changed:
func(
  - string, 
  string
)
  • IncRetry — Type changed:
func(
  - string, 
  string
)
  • IncStoppedResending — Type changed:
func(
  string, 
  - string, 
  int
)
  • ObserveTimeToAck — Type changed:
func(
  string, 
  - string, 
  time.Duration, 
  int
)
pkg/capabilities.BaseTriggerMetrics (4)
  • IncAck — Type changed:
func(
  - string, 
  string
)
  • IncRetry — Type changed:
func(
  - string, 
  string
)
  • IncStoppedResending — Type changed:
func(
  string, 
  - string, 
  int
)
  • ObserveTimeToAck — Type changed:
func(
  string, 
  - string, 
  time.Duration, 
  int
)

📄 View full apidiff report

@DylanTinianov DylanTinianov force-pushed the base-trigger-metrics-fix branch from 365643c to ceafbbb Compare July 13, 2026 20:43
@DylanTinianov DylanTinianov added this pull request to the merge queue Jul 14, 2026
Merged via the queue into main with commit 475cb09 Jul 14, 2026
31 of 32 checks passed
@DylanTinianov DylanTinianov deleted the base-trigger-metrics-fix branch July 14, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants