prevent array index out of range in feeHistoryEstimator#500
Merged
Conversation
Contributor
|
👋 yashnevatia, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
yashnevatia
changed the title
Contributor
📊 API Diff Results
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the EIP-1559 FeeHistoryEstimator against malformed eth_feeHistory responses to avoid runtime panics during dynamic gas price refresh.
Changes:
- Add a guard to error out when
eth_feeHistoryreturns an emptyBaseFeearray. - Add a unit test covering the empty-
BaseFeecase.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/gas/fee_history_estimator.go | Adds a defensive check to prevent out-of-range access when reading feeHistory.BaseFee[len-1]. |
| pkg/gas/fee_history_estimator_test.go | Adds a regression test asserting an error is returned when BaseFee is empty. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+262
to
+274
| t.Run("returns error when fee history has empty base fee", func(t *testing.T) { | ||
| client := mocks.NewFeeHistoryEstimatorClient(t) | ||
| feeHistoryResult := ðereum.FeeHistory{ | ||
| OldestBlock: big.NewInt(1), | ||
| BaseFee: []*big.Int{}, | ||
| } | ||
| client.On("FeeHistory", mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(feeHistoryResult, nil).Once() | ||
|
|
||
| cfg := gas.FeeHistoryEstimatorConfig{BlockHistorySize: 1} | ||
| u := gas.NewFeeHistoryEstimator(logger.Test(t), client, cfg, chainID, nil) | ||
| err := u.RefreshDynamicPrice() | ||
| assert.ErrorContains(t, err, "empty base fee") | ||
| }) |
amit-momin
reviewed
Jul 10, 2026
amit-momin
reviewed
Jul 10, 2026
amit-momin
previously approved these changes
Jul 10, 2026
amit-momin
reviewed
Jul 10, 2026
amit-momin
reviewed
Jul 10, 2026
ilija42
approved these changes
Jul 10, 2026
Unheilbar
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.