Wire Telemetry metric views config to Beholder and LOOP plugins#23085
Draft
pkcll wants to merge 1 commit into
Draft
Wire Telemetry metric views config to Beholder and LOOP plugins#23085pkcll wants to merge 1 commit into
pkcll wants to merge 1 commit into
Conversation
Expose MetricViewsDisabled and MetricViewsAttributeBlacklist in core.toml, forward through shell and loop registry, and bump chainlink-common to the extended filter-views commit for companion PR #2238.
Contributor
|
✅ No conflicts with other open PRs targeting |
Contributor
|
I see you updated files related to
|
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to chainlink-common #2238 and stacks on chainlink #23084.
MetricViewsDisabledandMetricViewsAttributeBlacklistto[Telemetry]incore.toml(defaults:false,["event_id"])shell.gobeholder client, and LOOP plugin env forwardingchainlink-commonto extended filter-views commit6a12990d(PR Bump go.dedis.ch/kyber/v3 from 3.0.11 to 3.0.12 #2238 with attribute blacklist)Test plan
go test ./core/services/chainlink/... ./plugins/...go.modresolves after common Bump go.dedis.ch/kyber/v3 from 3.0.11 to 3.0.12 #2238 mergespk/chip-improvementsor merged stack; confirmevent_iddropped from exported metricsMerge order
common #2225 → common #2238 → chainlink #23084 → this PR
Made with Cursor