Conversation
|
👋 mchain0, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|
I see you updated files related to
|
|
✅ No conflicts with other open PRs targeting |
|
| if r := recover(); r != nil { | ||
| err = fmt.Errorf("workflow module execution panicked: %v", r) | ||
| e.logger().Errorw("Recovered from panic during workflow module execution", "err", err, "stack", string(debug.Stack())) | ||
| } |
There was a problem hiding this comment.
Arbitrary recovers are not safe. The node may be in a bad state. If we need to recover in order to record the result and prevent a boot loop, that may be OK, but it is important to rethrow the panic afterwards so that we get a full reset from the reboot, rather than continuing in an unknown state.
2 participants
cre-5476