Skip to content

DON-Level Metrics: Emit classified workflow errors#23136

Merged
DylanTinianov merged 6 commits into
developfrom
CRE-5483-classified-execution-status
Jul 20, 2026
Merged

DON-Level Metrics: Emit classified workflow errors#23136
DylanTinianov merged 6 commits into
developfrom
CRE-5483-classified-execution-status

Conversation

@DylanTinianov

@DylanTinianov DylanTinianov commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Updates workflow engine to emit classified workflow errors (user vs system) to be picked up by the workflow prober for don level metrics o11y.

@DylanTinianov DylanTinianov self-assigned this Jul 15, 2026
@DylanTinianov
DylanTinianov marked this pull request as ready for review July 15, 2026 19:11
@DylanTinianov
DylanTinianov requested review from a team as code owners July 15, 2026 19:11
patrickhuie19
patrickhuie19 reviewed Jul 15, 2026
View reviewed changes
Comment thread core/services/workflows/events/emit.go
@DylanTinianov DylanTinianov added build-test-image Will build the e2e test image in integration-tests workflow for PRs build-publish Build and Publish image to SDLC labels Jul 16, 2026
patrickhuie19
patrickhuie19 reviewed Jul 16, 2026
View reviewed changes
Comment thread core/scripts/go.mod Outdated
patrickhuie19
patrickhuie19 reviewed Jul 16, 2026
View reviewed changes
Comment thread core/services/workflows/engine.go
@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@DylanTinianov DylanTinianov changed the title Emit classified workflow errors DON-Level Metrics: Emit classified workflow errors Jul 16, 2026
@trunk-io

trunk-io Bot commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Static Badge   Static Badge   Static Badge   Static Badge

Failed Test Failure Summary Logs
Test_CCIP_Messaging_Sui2EVM_Success The test failed without a specific error message indicating what went wrong. Logs ↗︎
Test_CCIP_Messaging_Sui2EVM_Success/Message_to_EVM The test failed because it did not find any commit report events on the blockchain within the expected timeout period. Logs ↗︎

View Full Report ↗︎ ⋅ Docs

patrickhuie19
patrickhuie19 previously approved these changes Jul 16, 2026
View reviewed changes
@DylanTinianov
DylanTinianov enabled auto-merge July 17, 2026 14:06
tarcisiozf
tarcisiozf previously approved these changes Jul 17, 2026
View reviewed changes
@DylanTinianov
DylanTinianov dismissed stale reviews from tarcisiozf and patrickhuie19 via f50aae1 July 20, 2026 14:07
@cl-sonarqube-production

cl-sonarqube-production Bot commented Jul 20, 2026

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@DylanTinianov
DylanTinianov added this pull request to the merge queue Jul 20, 2026
Merged via the queue into develop with commit aa67b6b Jul 20, 2026
349 of 351 checks passed
@DylanTinianov
DylanTinianov deleted the CRE-5483-classified-execution-status branch July 20, 2026 17:39
This was referenced Jul 20, 2026
Draft
Draft
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarcisiozf tarcisiozf tarcisiozf approved these changes
@patrickhuie19 patrickhuie19 patrickhuie19 approved these changes
@vyzaldysanchez vyzaldysanchez Awaiting requested review from vyzaldysanchez
@kalverra kalverra Awaiting requested review from kalverra

Assignees

@DylanTinianov DylanTinianov

Labels

build-publish Build and Publish image to SDLC build-test-image Will build the e2e test image in integration-tests workflow for PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DylanTinianov @tarcisiozf @patrickhuie19