go fix ./...

core/auth/auth.go

@@ -1,14 +1,14 @@
 package auth
 
 import (
+	"crypto/sha3"
 	"encoding/hex"
 	"fmt"
+	"hash"
 
 	pkgerrors "github.com/pkg/errors"
 
 	"github.com/smartcontractkit/chainlink/v2/core/utils"
-
-	"golang.org/x/crypto/sha3"
 )
 
 var (
@@ -55,7 +55,7 @@ func hashInput(ta *Token, salt string) []byte {
 // HashedSecret generates a hashed password for an external initiator
 // authentication
 func HashedSecret(ta *Token, salt string) (string, error) {
-	hasher := sha3.New256()
+	hasher := hash.Hash(sha3.New256())
 	_, err := hasher.Write(hashInput(ta, salt))
 	if err != nil {
 		return "", pkgerrors.Wrap(err, "error writing external initiator authentication to hasher")

core/capabilities/ccip/ccipevm/msghasher_test.go

@@ -8,7 +8,8 @@ import (
 	"encoding/hex"
 	"encoding/json"
 	"fmt"
-	"io/ioutil"
+	"os"
+
 	"math/big"
 	"math/rand"
 	"strings"
@@ -464,7 +465,7 @@ func TestMessagerHasher_againstRmnSharedVector(t *testing.T) {
 		// onramp address: 0x89559ce6904d4c4b0f6aab9065ad02b1ed531be4
 		// sequence numbers 386 to 419.
 		var msgs []cciptypes.Message
-		data, err := ioutil.ReadFile("msgs_test_vector.json")
+		data, err := os.ReadFile("msgs_test_vector.json")
 		require.NoError(t, err)
 
 		err = json.Unmarshal(data, &msgs)

core/capabilities/ccip/ccipsolana/extradatacodec.go

@@ -52,7 +52,7 @@ func (d ExtraDataDecoder) DecodeExtraArgsToMap(extraArgs cciptypes.Bytes) (map[s
 			return nil, fmt.Errorf("failed to decode extra args: %w", err)
 		}
 		val = reflect.ValueOf(args)
-		typ = reflect.TypeOf(args)
+		typ = reflect.TypeFor[fee_quoter.GenericExtraArgsV2]()
 	case string(svmExtraArgsV1Tag):
 		var args fee_quoter.SVMExtraArgsV1
 		decoder := agbinary.NewBorshDecoder(extraArgs[4:])
@@ -61,7 +61,7 @@ func (d ExtraDataDecoder) DecodeExtraArgsToMap(extraArgs cciptypes.Bytes) (map[s
 			return nil, fmt.Errorf("failed to decode extra args: %w", err)
 		}
 		val = reflect.ValueOf(args)
-		typ = reflect.TypeOf(args)
+		typ = reflect.TypeFor[fee_quoter.SVMExtraArgsV1]()
 	default:
 		return nil, fmt.Errorf("unknown extra args tag: %x", extraArgs[:4])
 	}

core/capabilities/ccip/ccipsolana/msghasher.go

@@ -151,7 +151,7 @@ func parseExtraDataMap(input map[string]any) (extraData, error) {
 					a[i] = solana.PublicKeyFromBytes(val[:])
 				}
 				accounts = a
-			case []interface{}: // LOOP gRPC converts [][32]byte -> []interface{}
+			case []any: // LOOP gRPC converts [][32]byte -> []interface{}
 				a := make([]solana.PublicKey, len(v))
 				for i, elem := range v {
 					bs, ok := elem.([]byte)

core/capabilities/ccip/ccipsolana/msghasher_test.go

@@ -141,7 +141,7 @@ func TestParseExtraDataMap_LOOPConvertedTypes(t *testing.T) {
 		"AccountIsWritableBitmap":  int64(6),       // LOOP: uint64 -> int64
 		"AllowOutOfOrderExecution": true,
 		"TokenReceiver":            receiver, // LOOP: [32]byte -> []byte
-		"Accounts": []interface{}{ // LOOP: [][32]byte -> []interface{}
+		"Accounts": []any{ // LOOP: [][32]byte -> []interface{}
 			account1,
 			account2,
 		},
@@ -194,7 +194,7 @@ func TestParseExtraDataMap_InvalidTypes(t *testing.T) {
 
 	t.Run("Accounts element wrong length", func(t *testing.T) {
 		input := map[string]any{
-			"Accounts": []interface{}{
+			"Accounts": []any{
 				[]byte{0x01, 0x02}, // not 32 bytes
 			},
 		}
@@ -204,7 +204,7 @@ func TestParseExtraDataMap_InvalidTypes(t *testing.T) {
 
 	t.Run("Accounts element wrong type", func(t *testing.T) {
 		input := map[string]any{
-			"Accounts": []interface{}{
+			"Accounts": []any{
 				"not bytes",
 			},
 		}

core/capabilities/ccip/configs/sui/chain_writer.go

@@ -32,8 +32,8 @@ func GetChainWriterConfig(publicKeyStr string) (types.ChainWriterConfig, error)
 						PTBCommands: []types.ChainWriterPTBCommand{
 							{
 								Type:     types.SuiPTBCommandMoveCall,
-								ModuleId: strPtr("offramp"),
-								Function: strPtr("commit"),
+								ModuleId: new("offramp"),
+								Function: new("commit"),
 								Params: []types.SuiFunctionParam{
 									{
 										Name:     "ref",
@@ -77,8 +77,8 @@ func GetChainWriterConfig(publicKeyStr string) (types.ChainWriterConfig, error)
 						PTBCommands: []types.ChainWriterPTBCommand{
 							{
 								Type:     types.SuiPTBCommandMoveCall,
-								ModuleId: strPtr("offramp"),
-								Function: strPtr("init_execute"),
+								ModuleId: new("offramp"),
+								Function: new("init_execute"),
 								Params: []types.SuiFunctionParam{
 									{
 										Name:      "ref",
@@ -116,8 +116,8 @@ func GetChainWriterConfig(publicKeyStr string) (types.ChainWriterConfig, error)
 							},
 							{
 								Type:     types.SuiPTBCommandMoveCall,
-								ModuleId: strPtr("offramp"),
-								Function: strPtr("finish_execute"),
+								ModuleId: new("offramp"),
+								Function: new("finish_execute"),
 								Params: []types.SuiFunctionParam{
 									{
 										Name:      "ref",
@@ -151,6 +151,8 @@ func GetChainWriterConfig(publicKeyStr string) (types.ChainWriterConfig, error)
 }
 
 // Helper function to convert a string to a string pointer
+//
+//go:fix inline
 func strPtr(s string) *string {
-	return &s
+	return new(s)
 }

core/capabilities/ccip/oraclecreator/observation_metrics_collector_test.go

@@ -232,17 +232,17 @@ func TestWrappedCounter_ConcurrentIncrements(t *testing.T) {
 	const incrementsPerGoroutine = 100
 	done := make(chan bool, numGoroutines)
 
-	for i := 0; i < numGoroutines; i++ {
+	for range numGoroutines {
 		go func() {
-			for j := 0; j < incrementsPerGoroutine; j++ {
+			for range incrementsPerGoroutine {
 				baseCounter.Inc()
 			}
 			done <- true
 		}()
 	}
 
 	// Wait for all goroutines
-	for i := 0; i < numGoroutines; i++ {
+	for range numGoroutines {
 		<-done
 	}
 

core/capabilities/fakes/confidential_http_action.go

@@ -121,7 +121,7 @@ func (fh *DirectConfidentialHTTPAction) SendRequest(ctx context.Context, metadat
 	method = strings.ToUpper(method)
 
 	// Prepare template data from loaded secrets
-	templateData := make(map[string]interface{})
+	templateData := make(map[string]any)
 	for k, v := range fh.secretsConfig.SecretsNames {
 		if len(v) == 1 {
 			templateData[k] = v[0]

core/capabilities/triggers/trigger_event_store.go

@@ -54,7 +54,7 @@ UPDATE ` + triggerPendingEventsTable + `
 SET last_sent_at = $3, attempts = $4
 WHERE trigger_id = $1 AND event_id = $2
 `
-	var lastSent interface{}
+	var lastSent any
 	if !lastSentAt.IsZero() {
 		lastSent = lastSentAt
 	}

core/capabilities/vault/capability_test.go

@@ -97,9 +97,7 @@ func TestCapability_CapabilityCall(t *testing.T) {
 	require.NoError(t, err)
 
 	var wg sync.WaitGroup
-	wg.Add(1)
-	go func() {
-		defer wg.Done()
+	wg.Go(func() {
 		for {
 			select {
 			case <-t.Context().Done():
@@ -116,7 +114,7 @@ func TestCapability_CapabilityCall(t *testing.T) {
 				}
 			}
 		}
-	}()
+	})
 
 	resp, err := capability.Execute(t.Context(), capabilities.CapabilityRequest{
 		Payload: anyproto,
@@ -196,9 +194,7 @@ func TestCapability_CapabilityCall_DuringSubscriptionPhase(t *testing.T) {
 	require.NoError(t, err)
 
 	var wg sync.WaitGroup
-	wg.Add(1)
-	go func() {
-		defer wg.Done()
+	wg.Go(func() {
 		for {
 			select {
 			case <-t.Context().Done():
@@ -215,7 +211,7 @@ func TestCapability_CapabilityCall_DuringSubscriptionPhase(t *testing.T) {
 				}
 			}
 		}
-	}()
+	})
 
 	resp, err := capability.Execute(t.Context(), capabilities.CapabilityRequest{
 		Payload: anyproto,
@@ -497,9 +493,7 @@ func TestCapability_CapabilityCall_SecretIdentifierOwnerMismatch(t *testing.T) {
 
 			if !tc.shouldReject {
 				var wg sync.WaitGroup
-				wg.Add(1)
-				go func() {
-					defer wg.Done()
+				wg.Go(func() {
 					for {
 						select {
 						case <-t.Context().Done():
@@ -515,7 +509,7 @@ func TestCapability_CapabilityCall_SecretIdentifierOwnerMismatch(t *testing.T) {
 							}
 						}
 					}
-				}()
+				})
 				defer wg.Wait()
 			}
 
@@ -584,9 +578,7 @@ func TestCapability_CapabilityCall_UsesMetadataWorkflowOwner(t *testing.T) {
 	require.NoError(t, err)
 
 	var wg sync.WaitGroup
-	wg.Add(1)
-	go func() {
-		defer wg.Done()
+	wg.Go(func() {
 		for {
 			select {
 			case <-t.Context().Done():
@@ -599,7 +591,7 @@ func TestCapability_CapabilityCall_UsesMetadataWorkflowOwner(t *testing.T) {
 				}
 			}
 		}
-	}()
+	})
 
 	_, err = capability.Execute(t.Context(), capabilities.CapabilityRequest{
 		Payload: anyproto,
@@ -664,9 +656,7 @@ func TestCapability_CapabilityCall_ForwardsRequestGetSecretsIdentity(t *testing.
 		forward     *vault.GetSecretsRequest
 		forwardedOK bool
 	)
-	wg.Add(1)
-	go func() {
-		defer wg.Done()
+	wg.Go(func() {
 		for {
 			select {
 			case <-t.Context().Done():
@@ -690,7 +680,7 @@ func TestCapability_CapabilityCall_ForwardsRequestGetSecretsIdentity(t *testing.
 				return
 			}
 		}
-	}()
+	})
 
 	_, err = capability.Execute(t.Context(), capabilities.CapabilityRequest{
 		Payload: anyproto,
@@ -759,9 +749,7 @@ func TestCapability_CapabilityCall_BackfillsGetSecretsWorkflowOwnerFromFirstSecr
 		forward     *vault.GetSecretsRequest
 		forwardedOK bool
 	)
-	wg.Add(1)
-	go func() {
-		defer wg.Done()
+	wg.Go(func() {
 		for {
 			select {
 			case <-t.Context().Done():
@@ -785,7 +773,7 @@ func TestCapability_CapabilityCall_BackfillsGetSecretsWorkflowOwnerFromFirstSecr
 				return
 			}
 		}
-	}()
+	})
 
 	_, err = capability.Execute(t.Context(), capabilities.CapabilityRequest{
 		Payload: anyproto,
@@ -846,9 +834,7 @@ func TestCapability_CapabilityCall_ReturnsIncorrectType(t *testing.T) {
 	require.NoError(t, err)
 
 	var wg sync.WaitGroup
-	wg.Add(1)
-	go func() {
-		defer wg.Done()
+	wg.Go(func() {
 		for {
 			select {
 			case <-t.Context().Done():
@@ -865,7 +851,7 @@ func TestCapability_CapabilityCall_ReturnsIncorrectType(t *testing.T) {
 				}
 			}
 		}
-	}()
+	})
 
 	_, err = capability.Execute(t.Context(), capabilities.CapabilityRequest{
 		Payload: anyproto,
@@ -924,9 +910,7 @@ func TestCapability_CapabilityCall_TimeOut(t *testing.T) {
 	require.NoError(t, err)
 
 	var wg sync.WaitGroup
-	wg.Add(1)
-	go func() {
-		defer wg.Done()
+	wg.Go(func() {
 		for {
 			select {
 			case <-t.Context().Done():
@@ -939,7 +923,7 @@ func TestCapability_CapabilityCall_TimeOut(t *testing.T) {
 				}
 			}
 		}
-	}()
+	})
 
 	_, err = capability.Execute(t.Context(), capabilities.CapabilityRequest{
 		Payload: anyproto,
@@ -1613,9 +1597,7 @@ func TestCapability_CRUD(t *testing.T) {
 			wait := func() {}
 			if tc.error == "" {
 				var wg sync.WaitGroup
-				wg.Add(1)
-				go func() {
-					defer wg.Done()
+				wg.Go(func() {
 					for {
 						select {
 						case <-t.Context().Done():
@@ -1629,7 +1611,7 @@ func TestCapability_CRUD(t *testing.T) {
 							}
 						}
 					}
-				}()
+				})
 				wait = wg.Wait
 			}