Skip to content

cre-5533: reconciliation match for engine (pt. 2)#23158

Merged
mchain0 merged 2 commits into
developfrom
cre-5533-p2
Jul 20, 2026
Merged

cre-5533: reconciliation match for engine (pt. 2)#23158
mchain0 merged 2 commits into
developfrom
cre-5533-p2

Conversation

@mchain0

@mchain0 mchain0 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

more extensive identity validation on restart, delete, activate and pause

ref. #23157

cre-5533

@github-actions

Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@github-actions

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@mchain0
mchain0 marked this pull request as ready for review July 17, 2026 15:02
@mchain0
mchain0 requested a review from a team as a code owner July 17, 2026 15:02
@mchain0
mchain0 enabled auto-merge July 17, 2026 15:06
Comment thread core/services/workflows/syncer/v2/handler.go
@trunk-io

trunk-io Bot commented Jul 17, 2026

Copy link
Copy Markdown

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

Comment thread core/services/workflows/syncer/v2/workflow_registry.go Outdated
@mchain0
mchain0 requested a review from cedric-cordenier July 20, 2026 12:19
@cl-sonarqube-production

Copy link
Copy Markdown

Quality Gate failed Quality Gate failed

Failed conditions
7.52% Technical Debt Ratio on New Code (required ≤ 4%)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE SonarQube for IDE

@mchain0
mchain0 added this pull request to the merge queue Jul 20, 2026
Merged via the queue into develop with commit 0a036ce Jul 20, 2026
224 of 225 checks passed
@mchain0
mchain0 deleted the cre-5533-p2 branch July 20, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants