Fix coinmetrics-lwba asset-quotes websocket parsing#5184
Closed
cawthorne wants to merge 1 commit into
Closed
Conversation
The LWBA transport switched to asset-quotes in #3187 but still parsed pair-quotes messages, causing websocket updates to fail and feed uptime to flap for assets like FRAX.
🦋 Changeset detectedLatest commit: 032fcf1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asset-quotesresponses (assetfield) instead of only legacypair-quotesresponses (pairfield)pairmessagesfrax_fraxasset-quotes messagesContext
coinmetrics-lwbasubscribes to/v4/timeseries-stream/asset-quotes, but after #3187 the handler still calledmessage.pair.split('-'). Real CoinMetrics responses useasset, so every websocket message failed to parse, cache never updated, and feed uptime could flap as the connection was repeatedly treated as unresponsive.This affects assets like FRAX when overridden to
frax_frax.Test plan
yarn test packages/sources/coinmetrics/test/unit/lwba.test.tsyarn test packages/sources/coinmetrics/test/integration/adapter-ws.test.tsyarn test packages/sources/coinmetrics-lwba/test/integration/adapter-ws.test.tsproviderIndicatedTimeUnixMsadvances continuously on live websocket stream