Skip to content

fix: column selection + latest Docker tag #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acmeguy merged 8 commits into from
Apr 18, 2026
Merged

fix: column selection + latest Docker tag #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
316599e
feat: map field opt-in UI, skip LLM toggle, start over button
acmeguy Mar 31, 2026
0af52c3
feat: add skip_llm parameter to smart_gen_dataschemas mutation
acmeguy Apr 15, 2026
2576ea6
fix: add missing selectedModelFields state declaration
acmeguy Apr 15, 2026
625b558
fix: compute excludedFields from selectedModelFields, add skip_llm to…
acmeguy Apr 18, 2026
e4f4ed1
ci: push latest tag on master builds
acmeguy Apr 18, 2026
8b47c00
fix: use explicit column selection instead of has_values filtering
acmeguy Apr 18, 2026
2e58d81
fix: include map/nested fields by default, fix column selection init
acmeguy Apr 18, 2026
bd7790c
Merge remote-tracking branch 'origin/master' into feat/map-field-opt-…
acmeguy Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/build-and-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,6 @@ jobs:
context: .
file: ./Dockerfile
push: true
tags: quicklookup/synmetrix-client-v2:${{ env.IMAGE_TAG }}
tags: |
quicklookup/synmetrix-client-v2:${{ env.IMAGE_TAG }}
quicklookup/synmetrix-client-v2:latest
Binary file added .yarn/install-state.gz
View file
Open in desktop
Binary file not shown.
29 changes: 12 additions & 17 deletions src/components/SmartGeneration/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1079,11 +1079,11 @@ const SmartGeneration: FC<SmartGenerationProps> = ({
}))
);
}
// Select all active columns by default
// Select only columns that have data — empty columns start unchecked
if (pd.columns?.length) {
const active = pd.columns
.filter(
(c: any) => c.has_values !== false && c.value_rows > 0
(c: any) => c.has_values !== false || c.value_rows > 0
)
.map((c: any) => c.name);
setSelectedColumns(new Set(active));
Expand Down Expand Up @@ -1209,12 +1209,10 @@ const SmartGeneration: FC<SmartGenerationProps> = ({
.filter((a) => a.selected)
.map((a) => ({ column: a.column, alias: a.alias }));

// Only pass selected_columns if user deselected some columns
const activeCount =
profileData?.columns?.filter(
(c: any) => c.has_values !== false && c.value_rows > 0
).length ?? 0;
const isSubset = selectedColumns.size < activeCount;
// Pass selected_columns whenever the user has deselected any columns
const totalColumns = profileData?.columns?.length ?? 0;
const isSubset =
selectedColumns.size > 0 && selectedColumns.size < totalColumns;

const result = await execSmartGen({
datasource_id: dataSource.id!,
Expand Down Expand Up @@ -1258,9 +1256,8 @@ const SmartGeneration: FC<SmartGenerationProps> = ({
if (requiredSet.has(key)) return true;
// Always include the count measure
if (f.name === "count" && f.member_type === "measure") return true;
// Opt-in sources: map, nested (ARRAY JOIN), AI-generated
if (f.source === "map" || f.source === "nested" || f.source === "ai")
return false;
// Opt-in: AI-generated fields start unchecked (user picks from suggestions)
if (f.source === "ai") return false;
// Everything else checked by default
return true;
};
Expand Down Expand Up @@ -1306,12 +1303,10 @@ const SmartGeneration: FC<SmartGenerationProps> = ({
.filter((a) => a.selected)
.map((a) => ({ column: a.column, alias: a.alias }));

// Only pass selected_columns if user deselected some columns
const applyActiveCount =
profileData?.columns?.filter(
(c: any) => c.has_values !== false && c.value_rows > 0
).length ?? 0;
const applyIsSubset = selectedColumns.size < applyActiveCount;
// Pass selected_columns whenever the user has deselected any columns
const applyTotalColumns = profileData?.columns?.length ?? 0;
const applyIsSubset =
selectedColumns.size > 0 && selectedColumns.size < applyTotalColumns;

// Compute excluded fields: all preview fields NOT in the user's selection
const allPreviewFields = [
Expand Down
2 changes: 2 additions & 0 deletions src/graphql/generated.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13961,6 +13961,7 @@ export const SmartGenDataSchemasDocument = gql`
$cube_name: String
$selected_ai_metrics: [String]
$selected_columns: [String]
$excluded_fields: [String]
$skip_llm: Boolean
) {
smart_gen_dataschemas(
Expand All @@ -13978,6 +13979,7 @@ export const SmartGenDataSchemasDocument = gql`
cube_name: $cube_name
selected_ai_metrics: $selected_ai_metrics
selected_columns: $selected_columns
excluded_fields: $excluded_fields
skip_llm: $skip_llm
) {
code
Expand Down
2 changes: 2 additions & 0 deletions src/graphql/gql/datasources.gql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ mutation SmartGenDataSchemas(
$cube_name: String
$selected_ai_metrics: [String]
$selected_columns: [String]
$excluded_fields: [String]
$skip_llm: Boolean
) {
smart_gen_dataschemas(
Expand All @@ -245,6 +246,7 @@ mutation SmartGenDataSchemas(
cube_name: $cube_name
selected_ai_metrics: $selected_ai_metrics
selected_columns: $selected_columns
excluded_fields: $excluded_fields
skip_llm: $skip_llm
) {
code
Expand Down