feat(standards): warn when .claude/ is not ignored - #182
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advances smartwatermelon/dev-env#178
Adds a repo-wide
claude-ignorecheck to the shared standards check, per the 2026-10-02 fleet decision..claude/__standards_probe__must be ignored by the committed rules (git check-ignore -q --no-index)..claude/may match an ignore rule (git ls-files -ci --exclude-standard -- .claude/). Negated shared files pass.::warning title=claude-ignorenaming the fix and dev-env#178.core.excludesFileis blanked for these git calls..git/info/excludecannot be, so a local clone that has one may pass where CI warns.Warning-only. The script always exits 0, including on git errors (those warn "not checked"). It becomes an error later, once the two deferred repos conform.
The
standards-check-v1tag is not moved. That is a separate release step after merge.Lives in
standards/check-claude-ignore.sh, called fromstandards/run-standards.shafter node-floor.--skip claude-ignoredisables it; there is no workflow input yet.Tests: new
tests/test-check-claude-ignore.sh(6 cases) plus one run-standards case proving it warns without failing the run. With a no-op stub checker, 4 of the 6 new cases fail; with the real script all pass.