Skip to content

Fix silently swallowed / unpropagated errors in bind, polling disconnect, and websocket writes #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devin-ai-integration wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix silently swallowed / unpropagated errors in bind, polling disconnect, and websocket writes #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd1cdec
Improve error propagation in server bind, polling disconnect, and web…
sanjomo Jul 25, 2026
8f0ea9e
Revert websocket ChannelFutureList change per review feedback
sanjomo Jul 25, 2026
4063eaf
Merge branch 'main' into devin/1784979117-error-handling
sanjomo Jul 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions netty-socketio-core/src/main/java/com/socketio4j/socketio/SocketIOServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,8 +608,10 @@ public Future<Void> startAsync() {
int actualPort = local.getPort();
configCopy.setPort(actualPort);
configuration.setPort(actualPort);
} catch (Exception ignore) {
} catch (Exception e) {
// keep configured port if localAddress is not InetSocketAddress
log.debug("Could not resolve actual bound port, keeping configured port {}",
configCopy.getPort(), e);
}
}
serverStatus.set(ServerStatus.STARTED);
Expand All @@ -618,7 +620,7 @@ public Future<Void> startAsync() {
fireAfterStart();
} else {
serverStatus.set(ServerStatus.INIT);
log.error("Failed to start server on port {}", configCopy.getPort());
log.error("Failed to start server on port {}", configCopy.getPort(), future.cause());
cleanUpResources(false);
}
});
Expand Down
5 changes: 3 additions & 2 deletions netty-socketio-core/src/main/java/com/socketio4j/socketio/handler/EncoderHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,9 @@ private void readVersion() throws IOException {
version = name + "/" + attrs.getValue("Bundle-Version");
break;
}
} catch (IOException E) {
// skip it
} catch (IOException e) {
// A single unreadable manifest must not prevent reading the others
log.debug("Skipping unreadable MANIFEST.MF while resolving version header", e);
}
}
}
Expand Down
5 changes: 5 additions & 0 deletions netty-socketio-core/src/main/java/com/socketio4j/socketio/transport/PollingTransport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,11 @@ private void handleMessage(FullHttpRequest req, UUID sessionId, QueryStringDecod
String origin = req.headers().get(HttpHeaderNames.ORIGIN);
if (queryDecoder.parameters().containsKey("disconnect")) {
ClientHead client = clientsBox.get(sessionId);
if (client == null) {
log.error("{} is not registered. Closing connection", sessionId);
sendError(ctx);
return;
}
client.onChannelDisconnect();
ctx.channel().writeAndFlush(new XHRPostMessage(origin, sessionId));
} else if (HttpMethod.POST.equals(req.method())) {
Expand Down
Loading