Close HTTP/2 request queue - #234
Merged
Merged
Conversation
samuel-williams-shopify
force-pushed
the
close-http2-request-queue
branch
from
July 29, 2026 06:39
f21b622 to
e14784f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
Async::Queue#closeto stop the HTTP/2 server request loop instead of enqueueing anilsentinel and discarding the queue reference.Closing preserves already queued requests, causes the consumer to receive
nilonce drained, and rejects late producers withAsync::Queue::ClosedError.Includes a focused test for the queue shutdown semantics.
Tests: 242 passed, 3 skipped. RuboCop: 128 files inspected, no offenses.