Add warning for implicit relative imports issues#49
Open
Eddy114514 wants to merge 3 commits intosoftdevteam:migrationfrom
Open
Add warning for implicit relative imports issues#49Eddy114514 wants to merge 3 commits intosoftdevteam:migrationfrom
Eddy114514 wants to merge 3 commits intosoftdevteam:migrationfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 2 supports implicit relative imports inside packages. A bare import inside a package can resolve to a sibling module.
Example package:
In Python 2, this can resolve to:
In Python 3, imports are absolute by default, so the same code resolves as:
This means the code can import a different top-level module or fail with
ImportError.For same environment of
Python 2 resolves to pkg.foo
Python 3 resolves to top-level foo
I modified import.c to fire warning only if
To ensure above, I checks whether the resolved module name is:
current_package + "." + imported_nameFor example:
pkg + "." + foo == pkg.fooIf that condition is true, the import depended on Python 2 implicit relative import behavior, so pygrate2 emits a warning.