Repository navigation
feat: new homepage - #1858
Closed
lursz wants to merge 80 commits into
Closed
feat: new homepage#1858lursz wants to merge 80 commits into
lursz wants to merge 80 commits into
Conversation
|
pkg.pr.new packages benchmark commit |
lursz
requested review from
aleksanderkatan,
cieplypolar,
iwoplaza,
reczkok and
sharabai
December 9, 2025 15:40
iwoplaza
reviewed
Dec 11, 2025
Collaborator
There was a problem hiding this comment.
The changes in this file are forcing code snippets in the docs to be dark mode. Also, I think the code snippets on the landing page should respect the light/dark mode settings, or it's at least something we should explore.
Contributor
Author
There was a problem hiding this comment.
Yeah I've just noticed, it replaced the theme for all code snippets. Would we like to have the exact same theme everywhere (homepage + docs) or keep them separated?
iwoplaza
reviewed
Dec 11, 2025
Collaborator
There was a problem hiding this comment.
The bg of the code editor doesn't fit the bg of the page. I think we'd need to create our own custom theme.
iwoplaza
reviewed
Dec 11, 2025
📊 Bundle Size Comparison
👀 Notable resultsStatic test results:No major changes. Dynamic test results:No major changes. 📋 All resultsClick to reveal the results table (334 entries).
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu. |
aleksanderkatan
left a comment
aleksanderkatan
left a comment
Member
There was a problem hiding this comment.
Nice page!
I know nothing about frontend, so I just leave some nits that came to me when looking at the page
Member
There was a problem hiding this comment.
Sometimes, when I hover over an example, it stays blurred (I don't hover over the link). Does it mean it fails to load?
Contributor
Author
There was a problem hiding this comment.
Yeah, it basically means that the example failed to load. Should happen pretty seldom tho
Member
There was a problem hiding this comment.
Well, it happened to me at least 3 times while testing, one of which was on my first ever hover after a refresh. I don't think we can ignore this
Contributor
Author
There was a problem hiding this comment.
It's really difficult to reproduce, this might be a race condition, will look into it
Member
There was a problem hiding this comment.
Can we get rid of this loading text?
Screen.Recording.2026-01-23.at.16.45.17.mov
Contributor
Author
There was a problem hiding this comment.
It's a feature not a bug! xd
(seriously tho, on weaker phones loading some of our examples takes a while)
Member
There was a problem hiding this comment.
Can we at least center it? Right now it definitely does not look intended
Member
There was a problem hiding this comment.
The horizontal line here is missing
Contributor
Author
There was a problem hiding this comment.
Nice catch. I just assumed this line is some figma overlay, my mistake
Collaborator
|
Superseded by #2331 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New landing page for TypeGPU, with interactive islands running TypeGPU examples
After running the dev script the new landing page is at:
http://localhost:4321/TypeGPU/new