Feat/android fgs survive task removal

.claude/skills/thread-safety-itc/SKILL.md

@@ -132,6 +132,7 @@ Per-quantum processable state (`ALWAYS_`/`CONDITIONAL_`/`NOT_PROCESSABLE`) is de
 | Non-primitive, can be written by audio thread | Triple buffer (see `AnalyserNode` for reference) |
 | CPU-heavy work, must not block JS or audio | `TaskOffloader` on a dedicated worker thread |
 | Context lifecycle (`resume`/`suspend`/`close`) | `scheduleContextPromise` → `pendingPromisesOffloader_` |
+| Platform code (Kotlin) must reach a C++ object with no JS runtime alive | Process-global handle (`ActiveRecorderHandle` — mutex + `weak_ptr`, registered by the HostObject ctor/dtor) + static-JNI `JavaClass` (`NativeRecorderControl`, no HybridData needed). Blocking calls run on a Kotlin executor (`goAsync()` in receivers), never a detached `std::thread` — Kotlin threads are already JNI-attached |
 
 ---
 

CLAUDE.md

@@ -31,6 +31,8 @@ packages/custom-node-generator/    # Code generation tooling
 - **New Architecture Ready**: Supports both old Bridge and new TurboModules/Fabric
 - **Optional FFmpeg**: Audio decoding via FFmpeg can be conditionally compiled out
 - **Audio Worklets**: JavaScript runs on the audio thread via React Native Worklets
+- **Notification-Driven Foreground Service (Android)**: `NotificationRegistry.showNotification` → `ForegroundServiceManager.subscribe` → `CentralizedForegroundService`; service lifetime follows notification visibility, never recorder/player state. The library manifest is empty — consuming apps declare the `<service>` (Expo plugin `withAudioAPI.ts` or manually), where `android:stopWithTask` (plugin option `androidFSStopWithTask`) decides whether the service and an in-progress recording survive task removal
+- **JS-Independent Recorder Control (Android)**: the recording notification's stop action must work after task removal, when no JS listener is reachable. `ActiveRecorderHandle` (common C++, one-slot `weak_ptr` registered by `AudioRecorderHostObject`) exposes the live recorder process-globally; Kotlin reaches it through the static-JNI `NativeRecorderControl` object (no HybridData/React context needed — the reverse of the `NativeFileInfo` pattern). Results of a native stop are stashed consume-once for `AudioRecorder.takeLastRecordingResult()`; `AudioRecorder.isRecordingOngoing()` probes for a recording that outlived the UI
 - **Testable C++ dependencies**: consumers take interface types (`std::shared_ptr<I…>`); construct concrete implementations only at platform bootstrap. Example: audio event registry (use `IAudioEventHandlerRegistry` more often than `AudioEventHandlerRegistry`).
 
 ### Native Module Entry Points

apps/common-app/src/App.tsx

@@ -181,10 +181,21 @@ const MainTabsScreen: FC = () => {
   );
 };
 
+// Routes notification taps (e.g. the recording notification's `deepLinkUri`)
+// straight to the right screen instead of the app's entry screen.
+const linking = {
+  prefixes: ['audioapi-example://'],
+  config: {
+    screens: {
+      RecordDemo: 'record',
+    },
+  },
+};
+
 const App: FC = () => {
   return (
     <GestureHandlerRootView style={styles.container}>
-      <NavigationContainer>
+      <NavigationContainer linking={linking}>
         <Stack.Navigator
           screenOptions={{
             headerShown: true,

apps/common-app/src/demos/Record/Record.tsx

@@ -3,7 +3,7 @@ import {
   AudioBuffer,
   AudioBufferSourceNode,
   AudioManager,
-  concatAudioFiles,
+  AudioRecorder,
   FileFormat,
   RecordingNotificationManager,
 } from 'react-native-audio-api';
@@ -21,7 +21,17 @@ import Status from './Status';
 import { RecordingState } from './types';
 
 const Record: FC = () => {
-  const [state, setState] = useState<RecordingState>(RecordingState.Idle);
+  // A recording can outlive this screen (and, with `stopWithTask: false`, the whole
+  // app UI). Mounting directly in the right state lets every child initialize from
+  // the live recorder instead of transitioning out of a transient Idle render.
+  const [state, setState] = useState<RecordingState>(() => {
+    if (!AudioRecorder.isRecordingOngoing()) {
+      return RecordingState.Idle;
+    }
+    return Recorder.isPaused()
+      ? RecordingState.Paused
+      : RecordingState.Recording;
+  });
   const [hasPermissions, setHasPermissions] = useState<boolean>(false);
   const [recordedBuffer, setRecordedBuffer] = useState<AudioBuffer | null>(
     null
@@ -51,9 +61,10 @@ const Record: FC = () => {
       contentText: paused ? 'Paused recording' : 'Recording...',
       paused,
       smallIconResourceName: 'logo',
-      pauseIconResourceName: 'pause',
-      resumeIconResourceName: 'resume',
       color: 0xff6200,
+      showStopAction: true,
+      deepLinkUri: 'audioapi-example://record',
+      usesChronometer: true,
     });
   };
 
@@ -118,6 +129,19 @@ const Record: FC = () => {
     setState(RecordingState.Recording);
   }, []);
 
+  const loadRecordedAudio = useCallback(
+    async (paths: string[]) => {
+      setState(RecordingState.Loading);
+
+      const audioBuffer = await audioContext.decodeAudioData(paths[0]);
+      setRecordedBuffer(audioBuffer);
+
+      setState(RecordingState.ReadyToPlay);
+      currentPositionSV.value = 0;
+    },
+    [currentPositionSV]
+  );
+
   const onStopRecording = useCallback(async () => {
     const info = await Recorder.stop();
     RecordingNotificationManager.hide();
@@ -130,15 +154,22 @@ const Record: FC = () => {
       return;
     }
 
-    const outputPath = info.paths[0].replace(/[^/]+$/, 'recording.m4a');
+    await loadRecordedAudio(info.paths);
+  }, [loadRecordedAudio]);
 
-    const finalPath = await concatAudioFiles(info.paths, outputPath);
-    const audioBuffer = await audioContext.decodeAudioData(finalPath);
-    setRecordedBuffer(audioBuffer);
+  // The stop action already stopped the recorder natively and hid the notification;
+  // here we only pick up the resulting files and sync the UI.
+  const onStopRecordingFromNotification = useCallback(async () => {
+    const info = AudioRecorder.takeLastRecordingResult();
 
-    setState(RecordingState.ReadyToPlay);
-    currentPositionSV.value = 0;
-  }, []);
+    if (!info || info.paths.length === 0) {
+      setRecordedBuffer(null);
+      setState(RecordingState.Idle);
+      return;
+    }
+
+    await loadRecordedAudio(info.paths);
+  }, [loadRecordedAudio]);
 
   const onPlayRecording = useCallback(() => {
     if (state !== RecordingState.ReadyToPlay) {
@@ -229,11 +260,21 @@ const Record: FC = () => {
 
   useEffect(() => {
     (async () => {
-      const permissionStatus = await AudioManager.checkRecordingPermissions();
+      const recordingPermissionStatus =
+        await AudioManager.checkRecordingPermissions();
 
-      if (permissionStatus === 'Granted') {
+      if (recordingPermissionStatus === 'Granted') {
         setHasPermissions(true);
       }
+
+      const notificationPermissionStatus =
+        await AudioManager.checkNotificationPermissions();
+      if (notificationPermissionStatus !== 'Granted') {
+        const result = await AudioManager.requestNotificationPermissions();
+        if (result !== 'Granted') {
+          console.warn('Notification permissions are not granted');
+        }
+      }
     })();
   }, []);
 
@@ -254,22 +295,50 @@ const Record: FC = () => {
       }
     );
 
+    const stopListener = RecordingNotificationManager.addEventListener(
+      'recordingNotificationStop',
+      () => {
+        console.log('Notification stop action received');
+        onStopRecordingFromNotification();
+      }
+    );
+
     return () => {
       pauseListener.remove();
       resumeListener.remove();
-      RecordingNotificationManager.hide();
+      stopListener.remove();
     };
-  }, [onPauseRecording, onResumeRecording]);
+  }, [onPauseRecording, onResumeRecording, onStopRecordingFromNotification]);
+
+  // An ongoing recording is picked up by the state initializer above; here we only
+  // collect the files of a recording that was stopped natively (notification stop
+  // action) while this screen was unmounted.
+  useEffect(() => {
+    if (AudioRecorder.isRecordingOngoing()) {
+      return;
+    }
+
+    const info = AudioRecorder.takeLastRecordingResult();
+    if (info && info.paths.length > 0) {
+      loadRecordedAudio(info.paths);
+    }
+  }, [loadRecordedAudio]);
 
   useEffect(() => {
-    Recorder.enableFileOutput({ rotateIntervalBytes: 1_000_000, format: FileFormat.M4A });
+    // Re-enabling file output during an ongoing recording replaces the file writer,
+    // which starts a new file and resets the duration — skip it when resyncing.
+    if (!AudioRecorder.isRecordingOngoing()) {
+      Recorder.enableFileOutput({ format: FileFormat.Wav });
+    }
 
     return () => {
+      // The recording and its notification intentionally stay alive when leaving this
+      // screen; they can be stopped from the notification or after coming back.
       stopPlayback();
-      Recorder.disableFileOutput();
-      Recorder.stop();
-      AudioManager.setAudioSessionActivity(false);
-      RecordingNotificationManager.hide();
+
+      if (!AudioRecorder.isRecordingOngoing()) {
+        AudioManager.setAudioSessionActivity(false);
+      }
     };
   }, [stopPlayback]);
 

apps/common-app/src/demos/Record/RecordingTime.tsx

@@ -1,71 +1,53 @@
-import React, { useEffect } from 'react';
-import { StyleSheet, TextInput } from 'react-native';
-import Animated, {
-  useAnimatedProps,
-  useSharedValue,
-} from 'react-native-reanimated';
+import React, { useEffect, useState } from 'react';
+import { StyleSheet, Text } from 'react-native';
 
 import { audioRecorder as Recorder } from '../../singletons';
 import { colors } from '../../styles';
 import { RecordingState } from './types';
 
-const AnimatedTextInput = Animated.createAnimatedComponent(TextInput);
+const IDLE_DURATION = '00:00:000';
+
+function formatDuration(elapsedSeconds: number) {
+  const minutes = Math.floor((elapsedSeconds % 3600) / 60)
+    .toString()
+    .padStart(2, '0');
+  const seconds = Math.floor(elapsedSeconds % 60)
+    .toString()
+    .padStart(2, '0');
+  const milliseconds = Math.floor((elapsedSeconds % 1) * 1000)
+    .toString()
+    .padStart(3, '0');
+
+  return `${minutes}:${seconds}:${milliseconds}`;
+}
 
 interface RecordingTimeProps {
   state: RecordingState;
 }
 
 const RecordingTime: React.FC<RecordingTimeProps> = ({ state }) => {
-  const durationStringSV = useSharedValue('00:00:000');
-  const isMountedSV = useSharedValue(true);
+  const [durationString, setDurationString] = useState(IDLE_DURATION);
 
   useEffect(() => {
-    isMountedSV.value = true;
     if (![RecordingState.Recording, RecordingState.Paused].includes(state)) {
-      durationStringSV.value = '00:00:00';
+      setDurationString(IDLE_DURATION);
       return;
     }
 
-    const interval = setInterval(() => {
-      if (!isMountedSV.value) {
-        return;
-      }
-
-      const elapsedSeconds = Recorder.getCurrentDuration();
+    const refreshDuration = () =>
+      setDurationString(formatDuration(Recorder.getCurrentDuration()));
 
-      const minutes = Math.floor((elapsedSeconds % 3600) / 60)
-        .toString()
-        .padStart(2, '0');
-      const seconds = Math.floor(elapsedSeconds % 60)
-        .toString()
-        .padStart(2, '0');
-      const milliseconds = Math.floor((elapsedSeconds % 1) * 1000)
-        .toString()
-        .padStart(3, '0');
-
-      durationStringSV.value = `${minutes}:${seconds}:${milliseconds}`;
-    }, 100);
+    // Also refresh immediately so a paused or resynced screen shows the real
+    // duration before the first interval tick.
+    refreshDuration();
+    const interval = setInterval(refreshDuration, 100);
 
     return () => {
-      isMountedSV.value = false;
       clearInterval(interval);
     };
-  }, [state, durationStringSV, isMountedSV]);
-
-  const animatedText = useAnimatedProps(() => {
-    return {
-      text: durationStringSV.value,
-      defaultValue: '00:00:000',
-    };
-  });
+  }, [state]);
 
-  return (
-    <AnimatedTextInput
-      editable={false}
-      animatedProps={animatedText}
-      style={styles.text}
-    />
-  );
+  return <Text style={styles.text}>{durationString}</Text>;
 };
 
 export default RecordingTime;