-
-
Notifications
You must be signed in to change notification settings - Fork 91
fix(ios): recording resume after an interruption #1257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SomePersonFromMars
wants to merge
13
commits into
main
Choose a base branch
from
fix/ios-recording-interrupted
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
2c35596
fix: issue #1220 suggested onInterruptionEnd update
SomePersonFromMars 0547b09
fix: minor tweaks to previous flawed patch
SomePersonFromMars b9fd96e
fix: add mixWithOthers to Recorder demo
SomePersonFromMars b93c5c1
fix: generalize handleInputConfigurationChange() to handle errors
SomePersonFromMars 523e5a4
fix: retry AudioEngine resume from interrupt when back foreground
SomePersonFromMars 1bfa489
fix: reopen a new rotating segment after capture loss instead of rota…
SomePersonFromMars 6283fb7
fix: retry AudioEngine resume only happens when interruption ended wa…
SomePersonFromMars bc74d58
fix: always perform native recovery after interruption notification
SomePersonFromMars f12b250
feat: observeAudioInterruptions(true) in the Record demo
SomePersonFromMars 86a9ae7
feat: document resuming recording after an interruption
SomePersonFromMars 673d326
fix: detach source node in player on failed start similarly to what r…
SomePersonFromMars d648901
fix: don't poison state on a no-op deactivation
SomePersonFromMars 33c3753
fix: recorder resume() only updates state on successful engine start
SomePersonFromMars File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.