Skip to content

build: remove reanimated and gesture-handler from dependencies - #1267

Merged
closetcaiman merged 3 commits into
mainfrom
build/update-dependencies
Sep 4, 2026
Merged

build: remove reanimated and gesture-handler from dependencies#1267
closetcaiman merged 3 commits into
mainfrom
build/update-dependencies

Conversation

@closetcaiman

@closetcaiman closetcaiman commented Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Closes #1265
Closes #1268

⚠️ Breaking changes ⚠️

  • N/A

Introduced changes

  • removed react-native-reanimated and react-native-gesture-handler from <Audio> dependencies
    • fallbacked to bare react-native API
  • bumped react-native-reanimated version to stable in common-app
  • bumped react-native-worklets to 0.12.1 in audio-worklets
    • reanimated currently enforces this version for their latest stable: reference
    • possibly a bug? - in shipped package.json they accept 0.12.x: reference

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code
  • Updated Web Audio API coverage
  • Added support for web
  • Updated old arch android spec file

@closetcaiman closetcaiman added build Changes affecting the build system, compilers, or external dependencies pkg:audio-api Core React Native audio control system compliant with the W3C Web Audio API spec labels Sep 2, 2026
@github-actions

github-actions Bot commented Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown

WPT non-regression comparison

ERROR — the comparison did not produce a report; the test run itself likely failed.

Workflow run · this comment is updated on every push.

@closetcaiman closetcaiman changed the title build: add reanimated and gesture-handler as dependencies build: remove reanimated and gesture-handler as dependencies Sep 3, 2026
@closetcaiman closetcaiman changed the title build: remove reanimated and gesture-handler as dependencies build: remove reanimated and gesture-handler from dependencies Sep 3, 2026
@closetcaiman
closetcaiman force-pushed the build/update-dependencies branch from 36b8278 to 12ef21b Compare September 3, 2026 14:41
@closetcaiman closetcaiman added the pkg:audio-worklets Integration of react-native-worklets for react-native-audio-api label Sep 3, 2026
@closetcaiman
closetcaiman marked this pull request as ready for review September 3, 2026 15:20
maciejmakowski2003
maciejmakowski2003 approved these changes Sep 4, 2026
View reviewed changes

@maciejmakowski2003 maciejmakowski2003 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job

@closetcaiman
closetcaiman merged commit 1b78480 into main Sep 4, 2026
10 of 12 checks passed
@closetcaiman
closetcaiman deleted the build/update-dependencies branch September 4, 2026 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maciejmakowski2003 maciejmakowski2003 maciejmakowski2003 approved these changes

Assignees

No one assigned

Labels

build Changes affecting the build system, compilers, or external dependencies pkg:audio-api Core React Native audio control system compliant with the W3C Web Audio API spec pkg:audio-worklets Integration of react-native-worklets for react-native-audio-api

Projects

None yet

Milestone

No milestone

2 participants

@closetcaiman @maciejmakowski2003