Skip to content

fix(constants): inline LIB_VERSION via codegen to fix compiled output #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marnelram wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(constants): inline LIB_VERSION via codegen to fix compiled output #1139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
afe9287
fix(constants): define LIB_VERSION in versions.ts and share with reso…
msluszniak May 12, 2026
97ac7dd
refactor(constants): rename VERSION_TAG to PREVIOUS_VERSION_TAG, prom…
msluszniak May 13, 2026
7b319d7
Merge remote-tracking branch 'origin/main' into fix/lib-version-codegen
msluszniak May 13, 2026
11eeeb3
refactor(constants): apply rename to FastSAM URLs from main merge
msluszniak May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
346 changes: 173 additions & 173 deletions packages/react-native-executorch/src/constants/modelUrls.ts
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions packages/react-native-executorch/src/constants/ocr/models.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import { alphabets, symbols } from './symbols';

import { URL_PREFIX, VERSION_TAG } from '../versions';
import { URL_PREFIX, PREVIOUS_VERSION_TAG } from '../versions';

const DETECTOR_CRAFT_MODEL = `${URL_PREFIX}-detector-craft/${VERSION_TAG}/xnnpack_quantized/xnnpack_craft_quantized.pte`;
const DETECTOR_CRAFT_MODEL = `${URL_PREFIX}-detector-craft/${PREVIOUS_VERSION_TAG}/xnnpack_quantized/xnnpack_craft_quantized.pte`;

const createHFRecognizerDownloadUrl = (alphabet: keyof typeof alphabets) =>
`${URL_PREFIX}-recognizer-crnn.en/${VERSION_TAG}/xnnpack/${alphabet}/xnnpack_crnn_${alphabet}.pte`;
`${URL_PREFIX}-recognizer-crnn.en/${PREVIOUS_VERSION_TAG}/xnnpack/${alphabet}/xnnpack_crnn_${alphabet}.pte`;

const RECOGNIZER_ENGLISH_CRNN = createHFRecognizerDownloadUrl('english');
const RECOGNIZER_LATIN_CRNN = createHFRecognizerDownloadUrl('latin');
Expand Down
4 changes: 2 additions & 2 deletions packages/react-native-executorch/src/constants/resourceFetcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export { LIB_VERSION } from './versions';

export const DOWNLOAD_EVENT_ENDPOINT =
'https://ai.swmansion.com/telemetry/downloads/api/downloads';

export const LIB_VERSION: string = require('../../package.json').version;
4 changes: 2 additions & 2 deletions packages/react-native-executorch/src/constants/tts/models.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { URL_PREFIX, VERSION_TAG } from '../versions';
import { URL_PREFIX, PREVIOUS_VERSION_TAG } from '../versions';

// Text to speech (tts) - Kokoro model(s)
const KOKORO_EN_MODELS_ROOT = `${URL_PREFIX}-kokoro/${VERSION_TAG}/xnnpack`;
const KOKORO_EN_MODELS_ROOT = `${URL_PREFIX}-kokoro/${PREVIOUS_VERSION_TAG}/xnnpack`;
const KOKORO_EN_SMALL_MODELS_ROOT = `${KOKORO_EN_MODELS_ROOT}/small`;
const KOKORO_EN_MEDIUM_MODELS_ROOT = `${KOKORO_EN_MODELS_ROOT}/medium`;

Expand Down
6 changes: 3 additions & 3 deletions packages/react-native-executorch/src/constants/tts/voices.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { KokoroVoiceExtras, VoiceConfig } from '../../types/tts';
import { URL_PREFIX, VERSION_TAG } from '../versions';
import { URL_PREFIX, PREVIOUS_VERSION_TAG } from '../versions';

// Kokoro voices - phonemizers
const KOKORO_PHONEMIZER_PREFIX = `${URL_PREFIX}-kokoro/${VERSION_TAG}/phonemizer`;
const KOKORO_PHONEMIZER_PREFIX = `${URL_PREFIX}-kokoro/${PREVIOUS_VERSION_TAG}/phonemizer`;
const KOKORO_PHONEMIZER_TAGGER_DATA = `${KOKORO_PHONEMIZER_PREFIX}/tags.json`;
const KOKORO_PHONEMIZER_LEXICON_EN_US_DATA = `${KOKORO_PHONEMIZER_PREFIX}/us_merged.json`;
const KOKORO_PHONEMIZER_LEXICON_EN_GB_DATA = `${KOKORO_PHONEMIZER_PREFIX}/gb_merged.json`;
Expand All @@ -17,7 +17,7 @@ const EN_GB_RESOURCES = {
} as KokoroVoiceExtras;

// Kokoro voices
const KOKORO_VOICE_PREFIX = `${URL_PREFIX}-kokoro/${VERSION_TAG}/voices`;
const KOKORO_VOICE_PREFIX = `${URL_PREFIX}-kokoro/${PREVIOUS_VERSION_TAG}/voices`;
/**
* @category TTS Supported Voices
*/
Expand Down
6 changes: 4 additions & 2 deletions packages/react-native-executorch/src/constants/versions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
export const LIB_VERSION = '0.9.0';

export const URL_PREFIX =
'https://huggingface.co/software-mansion/react-native-executorch';
export const VERSION_TAG = 'resolve/v0.8.0';
export const NEXT_VERSION_TAG = 'resolve/v0.9.0';
export const PREVIOUS_VERSION_TAG = 'resolve/v0.8.0';
export const VERSION_TAG = `resolve/v${LIB_VERSION}`;
Loading