Skip to content

[WIP] Calculate S-DAC carbon revenue [SAM-EM + BICYCLE-EM] [v3.14]#165

Open
softwareengineerprogrammer wants to merge 12 commits into
mainfrom
s-dac-carbon-revenue-3
Open

[WIP] Calculate S-DAC carbon revenue [SAM-EM + BICYCLE-EM] [v3.14]#165
softwareengineerprogrammer wants to merge 12 commits into
mainfrom
s-dac-carbon-revenue-3

Conversation

@softwareengineerprogrammer
Copy link
Copy Markdown
Owner

@softwareengineerprogrammer softwareengineerprogrammer commented Jun 3, 2026

Description

  1. Addresses S-DAC does not calculate carbon revenue NatLabRockies/GEOPHIRES-X#341. Models revenue via Other PBI Income.
  2. See also [WIP] S-DAC Carbon Revenue Fix [BICYCLE econ model] [v3.14] #153

TODO

  1. 🚧 SAM-EM support: e30dc21
    1. S-DAC-GT-2 example name/description finalization
    2. Account for electricity from grid
  2. Documentation
  3. Automatically set Do S-DAC-GT Calculations

Testing & Verification

  1. Unit tests added:
    1. S-DAC-GT-2
  2. Unit tests updated:
    1. S-DAC-GT
    2. test_parse_sdacgt_profile
  3. Manual testing:
    1. 🚧 Web interface:
      1. https://gtp.scientificwebservices.com/geophires/?geophires-example-id=S-DAC-GT
      2. https://gtp.scientificwebservices.com/geophires/?geophires-example-id=S-DAC-GT-2

Change Checklist:

Observe the following checklist items if your change includes a new version (see versioning notes and version management docs).

Before merging:

  1. I certify that I am a human and I have manually verified the correctness of the changes in this PR.
  2. Add a CHANGELOG entry (example). RST Template:
3.14: `TITLE <https://github.com/NREL/GEOPHIRES-X/pull/PR-NUMBER>`__ | `release <https://github.com/NREL/GEOPHIRES-X/releases/tag/v3.14.P>`__

After merging:

  1. Push tag(s) to GitHub: git push origin refs/tags/v3.14.P
  2. Post a change announcement to the GEOPHIRES Change Announcements Discussion (example). Markdown template:
3.14: [TITLE](https://github.com/NREL/GEOPHIRES-X/pull/PR-NUMBER) | [release](https://github.com/NREL/GEOPHIRES-X/releases/tag/vM.m.P)

Self-reviewed in #165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant