Make Starred the default landing tab; disable broken notification code#66
Merged
Conversation
Reorder bottom-nav to Starred / Today / All Tasks so the app opens on the Starred view. Tab indices extracted into named constants (_tabStarred, _tabToday, _tabAllTasks, _defaultTab) so future reorders touch a single place. Comments mark the lists whose order must match the constants. Notification code is commented out across NotificationService, main.dart call sites, and its test file. Daily 8 AM reminders weren't firing on the user's setup and disabling beats debugging a feature that's currently dead weight; packages stay in pubspec for an easy re-enable later. Refreshed manual-test SKILL.md with a rule requiring refresh / side-effect tests to spell out the mutation that produces the new state, so future agents don't generate vague "switch tab → reflects latest" tests. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The notification service file and its test file were block-commented in the previous commit. Update the coverage doc so the test count, file count, and "untested gaps" entry stay accurate. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Code review1 issue found.
|
Two fixes: 1. CI was failing because Flutter 3.44 (CI) flags `ReorderableListView`'s `onReorder` callback as deprecated. The replacement `onReorderItem` isn't available until Flutter 3.42, and the dev machine pins 3.41. Add an `// ignore: deprecated_member_use` comment with a note to swap when local Flutter is bumped, instead of breaking the local build. 2. Claude review flagged a stale claim in `docs/UI_VIEWS.md` about notification taps jumping to Today's 5 — that code path is commented out on this branch. Remove the sentence. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The previous attempt placed the // ignore: deprecated_member_use directive above an explanatory comment block, which broke the directive — the analyzer only honours it on the line directly above (or trailing) the offending code. Move it to a trailing comment on the same line as `onReorder:` to be unambiguous and survive future comment edits. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
`flutter test` exits 79 when a file registers zero tests, so the fully-commented file broke CI. Replace it with a single `skip:`-tagged placeholder so the runner sees the file as valid while the actual tests stay block-commented alongside the disabled service. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_AppShellState(_tabStarred,_tabToday,_tabAllTasks,_defaultTab) so any future reorder is a one-place change. Lists whose order must match the constants are marked with "MUST match" comments.NotificationServicebody, its call sites inmain.dart, and the matching test file are block-commented. Packages remain inpubspec.yamlso re-enabling is just an uncomment.Test plan
flutter analyzecleantest/app/app_test.dart: 1 baseline / 3 regression / 3 mechanism / 1 edge case)🤖 Generated with Claude Code