program: Improve account length validation#55
Merged
Merged
Conversation
joncinque
reviewed
May 13, 2026
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Looks great! Just one comment
| // SAFETY: There are no active borrows of the `metadata` account data and the | ||
| // account has been validated. | ||
| let header = unsafe { Header::from_bytes_mut_unchecked(metadata.borrow_unchecked_mut()) }; | ||
| let header = Header::from_bytes_mut(metadata_account_data)?; |
Contributor
There was a problem hiding this comment.
Since validate_metadata is actually checking the len, it should be possible to keep using the unchecked version here, no?
Contributor
Author
There was a problem hiding this comment.
Good point! It also validates that the account is mutable. Code updated in b130a01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently account length validation is done implicitly when reading account data. It would be better to do it explicitly.
Solution
Replace all uses of
from_bytes_uncheckedforfrom_bytes.