You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
NH-146966 PHP: explore and adopt declarative config - #219
This pull request introduces significant updates to naming conventions and configuration, aligning the project with new "swo_"-prefixed identifiers for propagators, samplers, and detectors. It also adds new component providers, updates example files and documentation, and improves compatibility with newer development tools. Below are the most important changes:
Adoption of "swo_" Naming Conventions:
Replaces all instances of solarwinds_http, swotracestate, xtraceoptions, and related identifiers with their new swo_-prefixed counterparts (e.g., swo_http, swo_tracestate, swo_xtraceoptions, etc.) across code, documentation, and examples for consistency and clarity. [1][2][3][4][5][6][7][8]
Component Provider and Configuration Enhancements:
Adds new component provider classes for Kubernetes, APM, and UAMS detectors, as well as for propagators, samplers, and span processors, and registers them in the composer.json under the spi section. [1][2][3]
Updates composer.json to reference the new registration files and updates development dependencies to newer versions for improved compatibility. [1][2]
Documentation and Example Updates:
Updates documentation (README.md, docs/azure-app-service-quickstart.md) to reflect the new configuration environment variables and table formatting, ensuring users follow the new conventions. [1][2][3][4]
Adds a new example (examples/basic_file.php and examples/basic_file.yaml) demonstrating configuration via file, including resource detection, propagators, response propagators, and tracer/meter/logger providers. [1][2]
Internal Refactoring and Compatibility:
Refactors the TransactionName API to use the new ResponseTimeSpanProcessor instead of the old TransactionNameSpanProcessor, updating attribute references accordingly. [1][2]
Updates PHPStan configuration (phpstan.neon.dist) to suppress specific errors and improve static analysis compatibility.
Constants and Known Values:
Updates and adds constants in KnownValues.php to match the new naming scheme and default values.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Five unresolved moderate issues affect example startup, settings initialization, and sampler configuration isolation.
No open issues 🎉
1 previously missed issue
In code that hasn't changed since last review
Resolve OTEL_CONFIG_FILE relative to the script directory
examples/basic_file.php:9
OTEL_CONFIG_FILE is resolved relative to the process working directory, not this script. Running php examples/basic_file.php from the repository root therefore looks for ./basic_file.yaml at the root, while the added file is in examples/, so the example cannot start; construct the path from __DIR__.
The reason will be displayed to describe this comment to others. Learn more.
Nit: could we rename this to maybe basic_config.yaml to differentiate from the instrumented file? Or should they match?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant updates to naming conventions and configuration, aligning the project with new "swo_"-prefixed identifiers for propagators, samplers, and detectors. It also adds new component providers, updates example files and documentation, and improves compatibility with newer development tools. Below are the most important changes:
Adoption of "swo_" Naming Conventions:
solarwinds_http,swotracestate,xtraceoptions, and related identifiers with their newswo_-prefixed counterparts (e.g.,swo_http,swo_tracestate,swo_xtraceoptions, etc.) across code, documentation, and examples for consistency and clarity. [1] [2] [3] [4] [5] [6] [7] [8]Component Provider and Configuration Enhancements:
composer.jsonunder thespisection. [1] [2] [3]composer.jsonto reference the new registration files and updates development dependencies to newer versions for improved compatibility. [1] [2]Documentation and Example Updates:
README.md,docs/azure-app-service-quickstart.md) to reflect the new configuration environment variables and table formatting, ensuring users follow the new conventions. [1] [2] [3] [4]examples/basic_file.phpandexamples/basic_file.yaml) demonstrating configuration via file, including resource detection, propagators, response propagators, and tracer/meter/logger providers. [1] [2]Internal Refactoring and Compatibility:
TransactionNameAPI to use the newResponseTimeSpanProcessorinstead of the oldTransactionNameSpanProcessor, updating attribute references accordingly. [1] [2]phpstan.neon.dist) to suppress specific errors and improve static analysis compatibility.Constants and Known Values:
KnownValues.phpto match the new naming scheme and default values.NH-146966