update ci/cd#262
Open
xuan-cao-swi wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens CI/CD workflows by pinning GitHub Actions to specific commit SHAs and by adding explicit permissions blocks to reduce default GITHUB_TOKEN privileges.
Changes:
- Pin commonly used actions (checkout, setup-ruby, codecov, upload-sarif, artifact, AWS creds, etc.) to commit SHAs.
- Add workflow-level
permissions: contents: readto multiple workflows to follow least-privilege defaults.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/verify_install.yml | Pins actions/checkout and ruby/setup-ruby to SHAs for install verification runs. |
| .github/workflows/run_unit_tests.yml | Adds explicit token permissions and pins checkout + codecov actions to SHAs. |
| .github/workflows/rubocop-analysis.yml | Adds permissions and pins checkout, setup-ruby, and upload-sarif actions to SHAs. |
| .github/workflows/codeql_analysis.yml | Adds workflow-level contents: read while keeping CodeQL pinned to SHAs. |
| .github/workflows/ci-reverse-lab.yml | Adds permissions and pins checkout, setup-ruby, and ReverseLabs scanner to SHAs. |
| .github/workflows/ci-markdownlint.yml | Adds permissions and pins checkout + markdownlint action to SHAs. |
| .github/workflows/ci-markdown-link.yml | Adds permissions and pins checkout + linkspector action to SHAs. |
| .github/workflows/build_publish_lambda_layer.yml | Pins checkout/artifact/download/AWS creds/ReverseLabs scanner actions to SHAs. |
| .github/workflows/build_for_github_package.yml | Adds permissions and pins checkout/setup-ruby/artifact/download/ReverseLabs scanner actions to SHAs. |
| .github/workflows/build_and_release_gem.yml | Adds workflow-level permissions and pins checkout/setup-ruby/release-gem/github-script/artifact/download/ReverseLabs scanner actions to SHAs. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
cheempz
reviewed
May 27, 2026
Contributor
cheempz
left a comment
cheempz
left a comment
There was a problem hiding this comment.
LGTM but wondering how accurate the copilot review about needing write permission because the lint and rubocop actions apparently ran fine with your initial change (https://github.com/solarwinds/apm-ruby/pull/262/commits, click the checkmark next to your first commit).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test (if applicable)