Skip to content

Default to .aab builds with Play Store#48

Open
arno-le wants to merge 3 commits into
solinor:masterfrom
arno-le:use-android-app-bundle
Open

Default to .aab builds with Play Store#48
arno-le wants to merge 3 commits into
solinor:masterfrom
arno-le:use-android-app-bundle

Conversation

@arno-le

@arno-le arno-le commented Oct 17, 2019

Copy link
Copy Markdown

Changed template Fastfile to use Android App Bundle as default.
Reasons to use .aab include smaller app size and no need to build for separate CPU architectures, as that is handled by the Play Store.
More info here:
https://developer.android.com/platform/technology/app-bundle

As of now, Crashlytics does not support .aab -format.

@plrdev

plrdev commented Dec 6, 2019

Copy link
Copy Markdown
Contributor

Hey thanks for the PR. This is definitely something we want to support, but probably would be good to make it a user decision, which option to choose from. It would require adding a prompt and changing the template depending on the choice. Would you be willing to add that?

@arno-le

arno-le commented Dec 18, 2019

Copy link
Copy Markdown
Author

Sure!

@arno-le

arno-le commented Jan 13, 2020

Copy link
Copy Markdown
Author

@eduplus Added a prompt to select the build variant. Additionally, I feel like the askQuestion method in android.js should be refactored or removed

@plrdev

plrdev commented Jan 23, 2020

Copy link
Copy Markdown
Contributor

Thanks, this looks good to me, @miguelrrc promised to check that it works with his (long in waiting) PR, which does a lot on Android side as well. Hopefully we can merge these both in soon.

@miguelrrc

Copy link
Copy Markdown
Collaborator

It is good to go! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants