Skip to content

feat: add optional ducking param to dubbing, default off (0.9.0) - #21

Merged
spencer-zqian merged 2 commits into
mainfrom
feat/dubbing-ducking
Jul 31, 2026
Merged

feat: add optional ducking param to dubbing, default off (0.9.0)#21
spencer-zqian merged 2 commits into
mainfrom
feat/dubbing-ducking

Conversation

@spencer-zqian

Copy link
Copy Markdown
Contributor

Propagates the dashboard's new dubbing ducking parameter (sonilo-api-dashboard#188, live in prod):

  • client.dubbing.submit()/generate() (sync + async) gain ducking: Optional[bool] = None — sent as the ducking form field only when set; omitted → server default (off).
  • Semantics: off (default) keeps the background music/effects bed at a constant level; True ducks the bed under the dubbed voice while it speaks. Free parameter; note the polarity is the opposite of the music endpoints' default-on ducking.
  • Test: true/false/unset form-body assertions. 218 passed.
  • No version bump in this PR — bump on release per repo convention.

@sapient-app

sapient-app Bot commented Jul 31, 2026

Copy link
Copy Markdown

Sapient docs evals

Waiting for the staging docs URL before running evals.

Sapient will start the selected PR evals automatically when GitHub reports a successful docs deployment for this PR. This usually happens within 15 minutes.

Commit: a5181eb
Status: waiting for staging docs URL

@spencer-zqian spencer-zqian changed the title feat: add optional ducking param to dubbing (default off) feat: add optional ducking param to dubbing, default off (0.9.0) Jul 31, 2026
@spencer-zqian
spencer-zqian merged commit 20321fc into main Jul 31, 2026
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant