Use pre-built ctags + build arm64 Docker images - #1130
Merged
keegancsmith merged 17 commits intoAug 14, 2026
Conversation
Contributor
Author
|
Looking into the test failure - may be due to the newer ctags version Edit: looks like the tests work again after moving the release back to early 2024 |
keegancsmith
approved these changes
Aug 13, 2026
keegancsmith
left a comment
Member
There was a problem hiding this comment.
Thanks!! Two minor inline comments then I can land.
Contributor
Author
|
@keegancsmith addressed both |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While investigating the option of making zoekt Docker builds multi-platform (arm64 and am64, not just amd64), I ran into a few virtualization problems, so decided to tackle the problem in a slightly different way than just plain qemu.
bumped the universal ctags version quite a bit- there are prebuilt binaries for the ~2024 version that was there previously -happy to move it back if you so wish- ended up using it as newer version have slight changes in their data structures, so decided not to conflate too many things hereSupersedes #1129