all: modernize and golangci-lint fixes - #1135
Merged
Merged
Conversation
The current Go toolchain can express several loops and string operations more directly. Apply the validated automated rewrites while excluding promoted-field selectors and the unsafe index-loop transformation. Amp-Thread-ID: https://ampcode.com/threads/T-019fff44-5b25-709a-a557-5b8daee9cf75
keegancsmith
changed the title
keegancsmith
marked this pull request as ready for review
August 14, 2026 09:23
burmudar
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This applies the validated rewrites suggested by modernize and golangci-lint, including standard-library helpers for reverse iteration and string manipulation, simpler formatting calls, and equivalent expression cleanup.
The most common mechanical change was seperated out to #1134
Note: one of the rewrites was incorrect and was not included: an unsafe reverse-loop rewrite