shards: simplify branch repository shard selection - #1136
Merged
Conversation
Consolidate adaptive selection around observed misses to remove duplicated preflight and saturated-query policies while preserving representative performance. Amp-Thread-ID: https://ampcode.com/threads/T-019fff6c-4f91-7019-8e25-c855421914f0 Co-authored-by: Amp <amp@ampcode.com>
keegancsmith
changed the title
keegancsmith
marked this pull request as ready for review
August 14, 2026 09:32
Member
Author
burmudar
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows #1127 by consolidating branch repository shard selection around observed misses. It removes the duplicated preflight scans, first-match sampling, and special saturated-query policy paths, reducing production code by 159 net lines while preserving the selection behavior introduced there.
In simplifying the code we regress on some microbenchmarks, but the absolute value is less than a microsecond. For the larger benchmarks we actually have an improvement of 3-6%.