search: allow custom index file openers - #1138
Open
aaaaaandrew wants to merge 1 commit into
Open
Conversation
Keep mmap as the default while allowing directory searchers to inject an alternative IndexFile implementation for initial loads and watcher reloads. Co-Authored-By: OpenAI Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IndexFileOpenerfor initial and watcher shard loadsindex.NewIndexFileand mmap behavior for every existing constructorThe opener hook lets deployments select an owned-buffer reader when filesystem
mapping lifetime semantics are unsuitable, without changing the default for
other users.
Closes #1137.
Test plan
go test ./...go test -race ./searchgo vet ./search