Skip to content

Replace cmark-gfm with an in-house implementation #2831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jviotti merged 3 commits into from
Sep 16, 2026
Merged

Replace cmark-gfm with an in-house implementation #2831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e8e7b5
Replace cmark-gfm with an in-house implementation
jviotti Sep 14, 2026
f148863
More
jviotti Sep 16, 2026
6a8f25b
Fix
jviotti Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,6 @@ if(SOURCEMETA_CORE_CSS)
endif()

if(SOURCEMETA_CORE_MARKDOWN)
find_package(CMarkGFM REQUIRED)
add_subdirectory(src/core/markdown)
endif()

Expand Down
1 change: 0 additions & 1 deletion DEPENDENCIES
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ vendorpull https://github.com/sourcemeta/vendorpull 89f348a97842e05aeab45d338d41
mimalloc https://github.com/microsoft/mimalloc v3.4.4
jsontestsuite https://github.com/nst/JSONTestSuite d64aefb55228d9584d3e5b2433f720ea8fd00c82
yaml-test-suite https://github.com/yaml/yaml-test-suite data-2022-01-17
cmark-gfm https://github.com/github/cmark-gfm 587a12bb54d95ac37241377e6ddc93ea0e45439b
uritemplate-test https://github.com/uri-templates/uritemplate-test 1eb27ab4462b9e5819dc47db99044f5fd1fa9bc7
pyca-cryptography https://github.com/pyca/cryptography 9747d06e83764e7f1ea4c04daf134cb8f861700b
wycheproof https://github.com/C2SP/wycheproof 6d7cccd0fcb1917368579adeeac10fe802f1b521
Expand Down
121 changes: 0 additions & 121 deletions cmake/FindCMarkGFM.cmake
View file
Open in desktop

This file was deleted.

10 changes: 10 additions & 0 deletions config.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,17 @@ foreach(component ${SOURCEMETA_CORE_COMPONENTS})
include("${CMAKE_CURRENT_LIST_DIR}/sourcemeta_core_text.cmake")
include("${CMAKE_CURRENT_LIST_DIR}/sourcemeta_core_css.cmake")
elseif(component STREQUAL "markdown")
include("${CMAKE_CURRENT_LIST_DIR}/sourcemeta_core_io.cmake")
include("${CMAKE_CURRENT_LIST_DIR}/sourcemeta_core_text.cmake")
include("${CMAKE_CURRENT_LIST_DIR}/sourcemeta_core_unicode.cmake")
include("${CMAKE_CURRENT_LIST_DIR}/sourcemeta_core_punycode.cmake")
include("${CMAKE_CURRENT_LIST_DIR}/sourcemeta_core_idna.cmake")
include("${CMAKE_CURRENT_LIST_DIR}/sourcemeta_core_dns.cmake")
include("${CMAKE_CURRENT_LIST_DIR}/sourcemeta_core_ip.cmake")
include("${CMAKE_CURRENT_LIST_DIR}/sourcemeta_core_uri.cmake")
include("${CMAKE_CURRENT_LIST_DIR}/sourcemeta_core_email.cmake")
include("${CMAKE_CURRENT_LIST_DIR}/sourcemeta_core_preprocessor.cmake")
include("${CMAKE_CURRENT_LIST_DIR}/sourcemeta_core_html.cmake")
include("${CMAKE_CURRENT_LIST_DIR}/sourcemeta_core_markdown.cmake")
elseif(component STREQUAL "diff")
include("${CMAKE_CURRENT_LIST_DIR}/sourcemeta_core_text.cmake")
Expand Down
9 changes: 6 additions & 3 deletions src/core/markdown/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
sourcemeta_library(NAMESPACE sourcemeta PROJECT core NAME markdown
PRIVATE_HEADERS error.h
SOURCES markdown.cc)

if(SOURCEMETA_CORE_INSTALL)
sourcemeta_library_install(NAMESPACE sourcemeta PROJECT core NAME markdown)
endif()

target_link_libraries(sourcemeta_core_markdown PRIVATE CMarkGFM::cmark_gfm)

target_link_libraries(sourcemeta_core_markdown PRIVATE
sourcemeta::core::unicode)
sourcemeta::core::email
sourcemeta::core::html
Comment thread
cubic-dev-ai[bot] marked this conversation as resolved.
sourcemeta::core::text
sourcemeta::core::unicode
sourcemeta::core::uri)
Loading