Skip to content

Fix MSVC deflate compiler errors #2836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jviotti merged 1 commit into from
Sep 15, 2026
+4 −4
Merged

Fix MSVC deflate compiler errors #2836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/core/gzip/deflate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ class DeflateBitWriter {

auto flush() -> void {
std::uint64_t word{this->buffer_};
if (std::endian::native == std::endian::big) {
if constexpr (std::endian::native == std::endian::big) {
word = std::byteswap(word);
}

Expand Down Expand Up @@ -542,7 +542,7 @@ class DeflateEncoder {
static auto load_32(const std::uint8_t *data) -> std::uint32_t {
std::uint32_t word{0};
std::memcpy(&word, data, sizeof(word));
if (std::endian::native == std::endian::big) {
if constexpr (std::endian::native == std::endian::big) {
word = std::byteswap(word);
}

Expand All @@ -552,7 +552,7 @@ class DeflateEncoder {
static auto load_64(const std::uint8_t *data) -> std::uint64_t {
std::uint64_t word{0};
std::memcpy(&word, data, sizeof(word));
if (std::endian::native == std::endian::big) {
if constexpr (std::endian::native == std::endian::big) {
word = std::byteswap(word);
}

Expand Down
2 changes: 1 addition & 1 deletion src/core/gzip/inflate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,7 +740,7 @@ class InflateDecoder {
static auto load_word(const std::uint8_t *data) -> std::uint64_t {
std::uint64_t word{0};
std::memcpy(&word, data, sizeof(word));
if (std::endian::native == std::endian::big) {
if constexpr (std::endian::native == std::endian::big) {
word = std::byteswap(word);
}

Expand Down