Fix preserve owner records and other improvements - #84
Merged
Conversation
The per-space/per-handle velocity limits are meant to cap cheap off-chain record churn (seq bumps). They were charged on every replacement, so a daily batch finalizing all previously-issued temp handles hit space_rate (100/min/space) and got silently dropped past the cap.
… URL canonicalization
The sync-failure demotion (record_sync_failure demotes a verified peer to unverified after 3 consecutive failures) was undercut because mark_alive cleared the counter, and mark_alive runs on a /health success too. A peer with a working /health but broken /sync had its count zeroed by every health refresh, so it only demoted if 3 sync failures landed between two refreshes — true for <=4 verified peers, false beyond that, leaving the broken peer winning sync slots forever (the exact case the demotion targets). mark_alive no longer clears sync_failures; a new mark_synced (called only on a real sync success) does. The health path keeps refreshing liveness without masking a broken /sync. Test updated to prove a health success does not reset the count and a sync success does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.