Conversation
Rescue referenced unset local +body+ instead of +env[:body]+, raising NoMethodError on every non-JSON response. Adds spec coverage. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
atomfbs
deleted the
Fix_ResoFaradayMiddleware_NoMethodError_on_XML_responses
branch
atomfbs
restored the
Fix_ResoFaradayMiddleware_NoMethodError_on_XML_responses
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rescue referenced unset local +body+ instead of +env[:body]+, raising NoMethodError on every non-JSON response. Adds spec coverage.
Summary
ResoFaradayMiddleware#on_completereferenced the localbodyvariable, butMultiJson.decoderaised beforebodywasassigned — leaving it nil.
.stripon nil raisedNoMethodErrorfor every non-JSON response, including legitimate RESO XML metadata
(
/Reso/OData/$metadata).env[:body](the raw body) instead.XML metadata regression, and genuine non-JSON/non-XML still raising
MultiJson::ParseError.Test plan
bundle exec rspec spec/unit/spark_api/reso_faraday_middleware_spec.rb— 4/4 pass