Fix IsResolved is not set to false despite associated Loan Return Preparations being deleted or unresolved

[Iwantexpresso]

Fixes #4883 and #8076

Previously there was an inconsistency between the isResolved checkbox not being properly set to false when deleting loan return preps. during debugging for this issue, there was a new issue found specific to Firefox browsers that occurred while manually creating loan return preps due to how it handled JSON field parsing. both are addressed within this pr. and both features should be working as intended.

Checklist

• Self-review the PR after opening it to make sure the changes look good and
  self-explanatory (or properly documented)
• Add relevant issue to release milestone
• Add pr to documentation list
• Add automated tests

Testing instructions

For Firefox Specifically ( #8076) :

• Create a CO with preparations, Note down the CO number.
• Create a loan for that specific CO, then import the loan preparations for that CO.
• Click on the Loan Return prep Subform, select quantity returned and quantity resolved to be any number less than or equal to the total quantity of loan preparations
• Make sure there is no longer an error related to the manual creation of LoanReturnPreps
• (optional) test these on a different browser to ensure functionality stayed the same between them

For any browser (#4883):

• Create a CO with preparations, Save CO Number.
• Create a loan for that specific CO, then import the loan preparations for that CO.
• Click on return loan button and select all preps
• make sure the isResolved box is checked
• click on loanReturnPrep subForm and delete them, then save the loan
• Make sure the isResolved box is unchecked
• Using the subform manually add loan return preps, then save.
• IsResolved checkbox remains unchecked until the amount of loan return preps is equivalent to the amount of loan preparations available

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 33cacfe3-1a82-41fb-88f5-21c0084d77a7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch issue-4883

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}