Skip to content

build(taskfile): stop leaving the volume-init container behind #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ilyes512 merged 2 commits into from
Sep 16, 2026
Merged

build(taskfile): stop leaving the volume-init container behind #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27b1722
build(taskfile): remove the volume-init container after every compose…
Ilyes512 Sep 16, 2026
8b5d7b2
build(taskfile): take the project's containers down in cleanup
Ilyes512 Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/instructions/executing-commands.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,11 @@ produces now. Never run it to make a red test green without reading the diff fir
service is a one-off container (`--rm`) under the `build` profile — it does not need to be
started before use.

Every task routed through `docker compose` removes the `volume-init` container it pulled in
through `depends_on` when it finishes, so a run leaves no stopped containers behind. The
teardown is visible in the output; it is not an error. `task cleanup` takes down whatever is
left of the project — containers and networks, but not the `cache` volume.

`task demo:record:<tape>` re-records `docs/demo/<tape>.tape` into `docs/static/demo/<tape>.gif`
inside the `vhs` Docker Compose service under the `demo` profile. It needs network access and
the Docker socket, and it always dirties the working tree — the same tape never produces
Expand Down
2 changes: 2 additions & 0 deletions Taskfile.dist.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ tasks:
FIXGID:
sh: echo ${FIXGID:-$(id -g)}
cmds:
- defer: docker compose rm --stop --force volume-init
- FIXUID={{ .FIXUID }} FIXGID={{ .FIXGID }} docker compose {{ .SUB_CMD }} {{ .CLI_ARGS }}

dc:build:
Expand Down Expand Up @@ -110,6 +111,7 @@ tasks:

The following files/dirs are excluded: none
cmds:
- docker compose --profile "*" down --remove-orphans
- git clean
-xd
--force