Fix P0 reliability bugs with regression tests - #2
Merged
Merged
Conversation
Stop the connection-monitor CPU spin, harden nil/store/stream paths, treat missing Badger keys as empty, allow cyclic protos to depth 7, and initialize new-workspace options. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Keep cyclic path/graph aligned on snip, return errors from store-backed APIs when the DB is unavailable, skip RetryConnection waits without a Wails context, and open/close stream channels without closing from the receive loop. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RetryConnection/ stream double-close panics, and grpcurlos.Exiton bad flagsgoogle.protobuf.Value) up to depth 7 then snip (upstream Supportgoogle.protobuf.Valuerogchap/wombat#100 / Cyclic dependency support rogchap/wombat#107 / PR Allow cyclic to depth 7 rogchap/wombat#111); initialize options for new workspacesTest plan
go test ./internal/app/ -count=1google.protobuf.Value/ FieldMask and confirm the form rendersMade with Cursor