fix(catalog): restore catalog links and icons#184
Conversation
|
Warning Review limit reached
Next review available in: 47 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughAdds an "official" trust badge icon to catalog result rows in both SSR ( ChangesCatalog trust badge, icon fixes, and landing link update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| Filename | Overview |
|---|---|
| apps/catalog/src/components/ResultList.astro | Static catalog rows now render the title-side official badge as decorative. |
| apps/catalog/src/scripts/virtual-results.ts | Virtualized catalog rows now match the static decorative official badge behavior. |
| apps/catalog/src/data/official-catalog.json | Official catalog entries now use refreshed icon URLs. |
| apps/landing/src/components/landing/Activation.astro | The landing page browse action now links to the public catalog. |
Reviews (2): Last reviewed commit: "fix(catalog): address review feedback" | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Preview DeployedLanding: https://pr-184.preview.caplets.dev Built from commit cfba500 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
apps/landing/test/activation-links.test.ts (1)
8-17: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAssert the rendered link, not the source text.
This passes even if
Buttonstops rendering an anchor or drops thehref, because it only checks the.astrosource string. RenderingActivation.astroand asserting the resulting link target would cover the behavior users actually rely on.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/landing/test/activation-links.test.ts` around lines 8 - 17, The current test in Activation-links.test.ts only inspects the Activation.astro source text, so it can pass even if Button no longer renders a real link. Update the test to render Activation.astro and assert against the rendered output for the browse-more action, using the existing test setup around Activation.astro and Button to verify the actual link target and presence of the anchor rather than the raw source string.apps/catalog/test/catalog-icon-metadata.test.ts (1)
17-23: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick winCover the CAPLET source files too.
This only guards
official-catalog.json, but the same icon URLs were also changed in thecaplets/*/CAPLET.mdsources. If those drift, the next catalog regeneration can reintroduce the broken URLs while this test still stays green. Add a paired assertion for the source Caplets, or compare the generated entries against them.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/catalog/test/catalog-icon-metadata.test.ts` around lines 17 - 23, The current stability check only validates the generated catalog in catalog-icon-metadata.test.ts, so it can miss drift in the CAPLET source markdown files. Update the test around stableIconUrls to also verify the matching caplets/*/CAPLET.md sources, either by asserting the source icon URLs directly or by comparing the generated catalog entries against those source files. Use the existing catalogPath/entries lookup pattern and the stableIconUrls mapping so both official-catalog.json and the CAPLET sources stay in sync.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/catalog/src/data/official-catalog.json`:
- Around line 1276-1280: The Neon catalog entry is using an icon URL that
redirects to a broken asset, so update the icon reference in the Neon item’s
catalog metadata to a reachable image URL. Change the `catalog.icon` value
alongside the matching `icon.url` entry in the same Neon record so the rendered
icon resolves correctly.
---
Nitpick comments:
In `@apps/catalog/test/catalog-icon-metadata.test.ts`:
- Around line 17-23: The current stability check only validates the generated
catalog in catalog-icon-metadata.test.ts, so it can miss drift in the CAPLET
source markdown files. Update the test around stableIconUrls to also verify the
matching caplets/*/CAPLET.md sources, either by asserting the source icon URLs
directly or by comparing the generated catalog entries against those source
files. Use the existing catalogPath/entries lookup pattern and the
stableIconUrls mapping so both official-catalog.json and the CAPLET sources stay
in sync.
In `@apps/landing/test/activation-links.test.ts`:
- Around line 8-17: The current test in Activation-links.test.ts only inspects
the Activation.astro source text, so it can pass even if Button no longer
renders a real link. Update the test to render Activation.astro and assert
against the rendered output for the browse-more action, using the existing test
setup around Activation.astro and Button to verify the actual link target and
presence of the anchor rather than the raw source string.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 908bf1a3-79f0-43c6-a877-a339dd85c2bf
📒 Files selected for processing (13)
apps/catalog/src/components/ResultList.astroapps/catalog/src/data/official-catalog.jsonapps/catalog/src/scripts/virtual-results.tsapps/catalog/src/styles/catalog.cssapps/catalog/test/catalog-icon-metadata.test.tsapps/catalog/test/virtual-results.test.tsapps/landing/src/components/landing/Activation.astroapps/landing/test/activation-links.test.tscaplets/neon/CAPLET.mdcaplets/notion/CAPLET.mdcaplets/sourcegraph/CAPLET.mdcaplets/supabase/CAPLET.mdcaplets/terraform/CAPLET.md
1 participant
Summary
The landing page's browse-more Caplets path now sends users to the live catalog instead of the GitHub source tree. Catalog rows also recover provider icons that were using dead or poorly served URLs, and official entries now show the trust badge directly beside the Caplet title while preserving the existing status column.
Validation
pnpm verify(pre-push hook)Summary by CodeRabbit
New Features
Bug Fixes
Tests