Upgrade JS-commons [WIP]

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@splitsoftware/splitio",
-  "version": "11.11.1",
+  "version": "11.11.2-rc.0",
   "description": "Split SDK",
   "files": [
     "README.md",
@@ -38,7 +38,7 @@
     "node": ">=14.0.0"
   },
   "dependencies": {
-    "@splitsoftware/splitio-commons": "2.12.0",
+    "@splitsoftware/splitio-commons": "3.0.0-rc.0",
     "bloom-filters": "^3.0.4",
     "ioredis": "^4.28.0 || ^5.0.0",
     "js-yaml": "^4.1.1",
@@ -99,7 +99,7 @@
     "test-browser-e2e-push": "cross-env NODE_ENV=test karma start karma/e2e.push.karma.conf.js",
     "test-node": "npm run test-node-unit && npm run test-node-e2e",
     "test-node-unit": "cross-env NODE_ENV=test tape -r ./ts-node.register \"src/*/**/__tests__/**/!(browser).spec.js\" | tap-min",
-    "test-node-e2e": "npm run test-node-e2e-online && npm run test-node-e2e-offline && npm run test-node-e2e-destroy && npm run test-node-e2e-errorCatching && npm run test-node-e2e-push && npm run test-node-e2e-redis",
+    "test-node-e2e": "npm run test-node-e2e-online && npm run test-node-e2e-offline && npm run test-node-e2e-destroy && npm run test-node-e2e-errorCatching && npm run test-node-e2e-push",
     "test-node-e2e-online": "cross-env NODE_ENV=test tape -r ./ts-node.register src/__tests__/online/node.spec.js | tap-min",
     "test-node-e2e-offline": "cross-env NODE_ENV=test tape -r ./ts-node.register src/__tests__/offline/node.spec.js | tap-min",
     "test-node-e2e-destroy": "cross-env NODE_ENV=test tape -r ./ts-node.register src/__tests__/destroy/node.spec.js | tap-min",

src/__tests__/browserSuites/ready-promise.spec.js

@@ -31,7 +31,7 @@ function assertGetTreatmentWhenReady(assert, client) {
 function assertGetTreatmentControlNotReady(assert, client) {
   consoleSpy.log.resetHistory();
   assert.equal(client.getTreatment('hierarchical_splits_test'), 'control', 'We should get control if client is not ready.');
-  assert.true(consoleSpy.log.calledWithExactly('[WARN]  splitio => getTreatment: the SDK is not ready to evaluate. Results may be incorrect for feature flag hierarchical_splits_test. Make sure to wait for SDK readiness before using this method.'), 'Telling us that calling getTreatment would return CONTROL since SDK is not ready at this point.');
+  assert.true(consoleSpy.log.calledWithExactly('[WARN]  splitio => getTreatment: the SDK is not ready to evaluate. Results may be incorrect. Make sure to wait for SDK readiness before using this method.'), 'Telling us that calling getTreatment would return CONTROL since SDK is not ready at this point.');
 }
 
 function assertGetTreatmentControlNotReadyOnDestroy(assert, client) {

src/__tests__/mocks/splitchanges.real.withSegments.json

@@ -66,57 +66,6 @@
           }
         ],
         "configurations": {}
-      },
-      {
-        "trafficTypeName": "user",
-        "name": "real_split_2",
-        "trafficAllocation": 100,
-        "trafficAllocationSeed": -1427479928,
-        "seed": 769174959,
-        "status": "ACTIVE",
-        "killed": false,
-        "defaultTreatment": "on",
-        "changeNumber": 1550099287990,
-        "algo": 2,
-        "conditions": [
-          {
-            "conditionType": "ROLLOUT",
-            "matcherGroup": {
-              "combiner": "AND",
-              "matchers": [
-                {
-                  "keySelector": {
-                    "trafficType": "user",
-                    "attribute": null
-                  },
-                  "matcherType": "ALL_KEYS",
-                  "negate": false,
-                  "userDefinedSegmentMatcherData": null,
-                  "whitelistMatcherData": null,
-                  "unaryNumericMatcherData": null,
-                  "betweenMatcherData": null,
-                  "booleanMatcherData": null,
-                  "dependencyMatcherData": null,
-                  "stringMatcherData": null
-                }
-              ]
-            },
-            "partitions": [
-              {
-                "treatment": "on",
-                "size": 100
-              },
-              {
-                "treatment": "off",
-                "size": 0
-              }
-            ],
-            "label": "default rule"
-          }
-        ],
-        "configurations": {
-          "on": "{\"color\":\"brown\",\"dimensions\":{\"height\":12,\"width\":14},\"text\":{\"inner\":\"click me\"}}"
-        }
       }
     ],
     "s": -1,

src/__tests__/nodeSuites/push-fallback.spec.js

@@ -27,7 +27,7 @@ import streamingResetMessage from '../mocks/message.STREAMING_RESET.json';
 import { nearlyEqual, mockSegmentChanges, url } from '../testUtils';
 
 import EventSourceMock, { setMockListener } from '../testUtils/eventSourceMock';
-import { __setEventSource } from '../../platform/getEventSource/node';
+import { __setEventSource } from '@splitsoftware/splitio-commons/src/platform/getEventSource/node';
 
 import { SplitFactory } from '../../';
 import { settingsFactory } from '../../settings';

src/__tests__/nodeSuites/push-flag-sets.spec.js

@@ -1,6 +1,6 @@
 import { SplitFactory } from '../..';
 import EventSourceMock, { setMockListener } from '../testUtils/eventSourceMock';
-import { __setEventSource } from '../../platform/getEventSource/node';
+import { __setEventSource } from '@splitsoftware/splitio-commons/src/platform/getEventSource/node';
 import { mockSegmentChanges } from '../testUtils';
 
 import notification1 from '../mocks/message.SPLIT_UPDATE.FS.1.json';

src/__tests__/nodeSuites/push-initialization-nopush.spec.js

@@ -8,7 +8,7 @@ import authInvalidCredentials from '../mocks/auth.invalidCredentials.txt';
 import authNoUserSpecified from '../mocks/auth.noUserSpecified.txt';
 import { nearlyEqual, url } from '../testUtils';
 
-import { __setEventSource, __restore } from '../../platform/getEventSource/node';
+import { __setEventSource, __restore } from '@splitsoftware/splitio-commons/src/platform/getEventSource/node';
 import EventSourceMock, { setMockListener } from '../testUtils/eventSourceMock';
 
 const baseUrls = {

src/__tests__/nodeSuites/push-initialization-retries.spec.js

@@ -7,7 +7,7 @@ import authPushBadToken from '../mocks/auth.pushBadToken.json';
 import { nearlyEqual, url } from '../testUtils';
 
 import EventSourceMock, { setMockListener } from '../testUtils/eventSourceMock';
-import { __setEventSource } from '../../platform/getEventSource/node';
+import { __setEventSource } from '@splitsoftware/splitio-commons/src/platform/getEventSource/node';
 
 import { SplitFactory } from '../../';
 import { settingsFactory } from '../../settings';

src/__tests__/nodeSuites/push-refresh-token.spec.js

@@ -7,7 +7,7 @@ import authPushDisabled from '../mocks/auth.pushDisabled.json';
 import { nearlyEqual, mockSegmentChanges, url } from '../testUtils';
 
 import EventSourceMock, { setMockListener } from '../testUtils/eventSourceMock';
-import { __setEventSource } from '../../platform/getEventSource/node';
+import { __setEventSource } from '@splitsoftware/splitio-commons/src/platform/getEventSource/node';
 
 import { SplitFactory } from '../../';
 import { settingsFactory } from '../../settings';

src/__tests__/nodeSuites/push-synchronization-retries.spec.js

@@ -13,7 +13,7 @@ import { nearlyEqual, mockSegmentChanges, url } from '../testUtils';
 import { Backoff } from '@splitsoftware/splitio-commons/src/utils/Backoff';
 
 import EventSourceMock, { setMockListener } from '../testUtils/eventSourceMock';
-import { __setEventSource } from '../../platform/getEventSource/node';
+import { __setEventSource } from '@splitsoftware/splitio-commons/src/platform/getEventSource/node';
 
 import { SplitFactory } from '../../';
 import { settingsFactory } from '../../settings';

src/__tests__/nodeSuites/push-synchronization.spec.js

@@ -30,7 +30,7 @@ import authPushEnabled from '../mocks/auth.pushEnabled.node.json';
 import { nearlyEqual, mockSegmentChanges, url, hasNoCacheHeader } from '../testUtils';
 
 import EventSourceMock, { setMockListener } from '../testUtils/eventSourceMock';
-import { __setEventSource } from '../../platform/getEventSource/node';
+import { __setEventSource } from '@splitsoftware/splitio-commons/src/platform/getEventSource/node';
 
 import { SplitFactory } from '../../';
 import { settingsFactory } from '../../settings';

src/__tests__/nodeSuites/ready-promise.spec.js

@@ -28,7 +28,7 @@ function assertGetTreatmentWhenReady(assert, client, key) {
 function assertGetTreatmentControlNotReady(assert, client, key) {
   consoleSpy.log.resetHistory();
   assert.equal(client.getTreatment(key, 'hierarchical_splits_test'), 'control', 'We should get control if client is not ready.');
-  assert.true(consoleSpy.log.calledWithExactly('[WARN]  splitio => getTreatment: the SDK is not ready to evaluate. Results may be incorrect for feature flag hierarchical_splits_test. Make sure to wait for SDK readiness before using this method.'), 'Telling us that calling getTreatment would return CONTROL since SDK is not ready at this point.');
+  assert.true(consoleSpy.log.calledWithExactly('[WARN]  splitio => getTreatment: the SDK is not ready to evaluate. Results may be incorrect. Make sure to wait for SDK readiness before using this method.'), 'Telling us that calling getTreatment would return CONTROL since SDK is not ready at this point.');
 }
 
 function assertGetTreatmentControlNotReadyOnDestroy(assert, client, key) {

src/__tests__/testUtils/nodeFetchMock.js

@@ -1,5 +1,5 @@
 import fetchMock from 'fetch-mock';
-import { __setFetch } from '../../platform/getFetch/node';
+import { __setFetch } from '@splitsoftware/splitio-commons/src/platform/getFetch/node';
 
 const sandboxFetchMock = fetchMock.sandbox();
 

src/factory/browser.js

@@ -14,7 +14,7 @@ import { createUserConsentAPI } from '@splitsoftware/splitio-commons/src/consent
 import { localhostFromObjectFactory } from '@splitsoftware/splitio-commons/src/sync/offline/LocalhostFromObject';
 
 import { settingsFactory } from '../settings/browser';
-import { platform, SignalListener } from '../platform';
+import { platform } from '../platform';
 
 const syncManagerOnlineCSFactory = syncManagerOnlineFactory(pollingManagerCSFactory, pushManagerFactory);
 
@@ -47,8 +47,6 @@ function getModules(settings) {
 
     sdkClientMethodFactory: sdkClientMethodCSFactory,
 
-    SignalListener,
-
     impressionsObserverFactory: impressionObserverCSFactory,
 
     extraProps: (params) => {

src/factory/node.js

@@ -14,8 +14,8 @@ import { isConsumerMode } from '@splitsoftware/splitio-commons/src/utils/setting
 
 import { localhostFromFileFactory } from '../sync/offline/LocalhostFromFile';
 import { settingsFactory } from '../settings/node';
-import { platform, SignalListener } from '../platform';
-import { bloomFilterFactory } from '../platform/filter/bloomFilter';
+import { platform } from '../platform';
+import { bloomFilterFactory } from '@splitsoftware/splitio-commons/src/utils/filter/bloomFilter';
 
 const syncManagerOnlineSSFactory = syncManagerOnlineFactory(pollingManagerSSFactory, pushManagerFactory);
 
@@ -46,8 +46,6 @@ function getModules(settings) {
 
     sdkClientMethodFactory,
 
-    SignalListener,
-
     impressionsObserverFactory: impressionObserverSSFactory,
 
     filterAdapterFactory: bloomFilterFactory,