Skip to content

Codex/aip 4614 pr153 review fixes - #162

Draft
kupratyu-splunk wants to merge 4 commits into
ai-tier-gafrom
codex/AIP-4614-pr153-review-fixes
Draft

Codex/aip 4614 pr153 review fixes#162
kupratyu-splunk wants to merge 4 commits into
ai-tier-gafrom
codex/AIP-4614-pr153-review-fixes

Conversation

@kupratyu-splunk

Copy link
Copy Markdown
Collaborator

Description

Related Issues

  • Related to #

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test improvement
  • CI/CD improvement
  • Chore (dependency updates, etc.)

Changes Made

Testing Performed

  • Unit tests pass (make test)
  • Linting passes (make lint)
  • Integration tests pass (if applicable)
  • E2E tests pass (if applicable)
  • Manual testing performed

Test Environment

  • Kubernetes Version:
  • Cloud Provider:
  • Deployment Method:

Test Steps

Documentation

  • Updated inline code comments
  • Updated README.md (if adding features)
  • Updated API documentation
  • Updated deployment guides
  • Updated CHANGELOG.md
  • No documentation needed

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published
  • I have updated the Helm chart version (if applicable)
  • I have updated CRD schemas (if applicable)

Breaking Changes

Impact:

Migration Path:

Screenshots/Recordings

Additional Notes

Reviewer Notes

Please pay special attention to:


Commit Message Convention: This PR follows Conventional Commits

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 05cf4c14c9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +490 to +493
elif [[ "${K0S_VERSION:-}" =~ ^v?([0-9]+\.[0-9]+\.[0-9]+)\+k0s ]]; then
PREREQ_RESOLVED_KUBECTL_VERSION="v${BASH_REMATCH[1]}"
else
PREREQ_RESOLVED_KUBECTL_VERSION="${PREREQ_KUBECTL_PINNED_VERSION}"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Propagate the staged k0s version into kubectl selection

When an air-gapped deployment selects an older release with airgap_install.sh --k0s-version ..., that assignment is shell-local and neither the generated airgap-env.sh nor the callback at the end of the wrapper exports it. Consequently, the callback's prerequisite check cannot take this branch and silently selects the locked v1.36.1 kubectl instead; choosing a k0s release more than one minor away can therefore install a client outside Kubernetes' supported version skew. Export the resolved k0s version to the callback/resume environment, or persist an equivalent kubectl version in the bundle.

Useful? React with 👍 / 👎.

@kupratyu-splunk
kupratyu-splunk force-pushed the codex/AIP-4614-pr153-review-fixes branch from 05cf4c1 to 5fba505 Compare August 11, 2026 12:47
@kupratyu-splunk
kupratyu-splunk marked this pull request as draft August 12, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant