Codex/aip 4614 pr153 review fixes - #162
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 05cf4c14c9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| elif [[ "${K0S_VERSION:-}" =~ ^v?([0-9]+\.[0-9]+\.[0-9]+)\+k0s ]]; then | ||
| PREREQ_RESOLVED_KUBECTL_VERSION="v${BASH_REMATCH[1]}" | ||
| else | ||
| PREREQ_RESOLVED_KUBECTL_VERSION="${PREREQ_KUBECTL_PINNED_VERSION}" |
There was a problem hiding this comment.
Propagate the staged k0s version into kubectl selection
When an air-gapped deployment selects an older release with airgap_install.sh --k0s-version ..., that assignment is shell-local and neither the generated airgap-env.sh nor the callback at the end of the wrapper exports it. Consequently, the callback's prerequisite check cannot take this branch and silently selects the locked v1.36.1 kubectl instead; choosing a k0s release more than one minor away can therefore install a client outside Kubernetes' supported version skew. Export the resolved k0s version to the callback/resume environment, or persist an equivalent kubectl version in the bundle.
Useful? React with 👍 / 👎.
05cf4c1 to
5fba505
Compare
Description
Related Issues
Type of Change
Changes Made
Testing Performed
make test)make lint)Test Environment
Test Steps
Documentation
Checklist
Breaking Changes
Impact:
Migration Path:
Screenshots/Recordings
Additional Notes
Reviewer Notes
Please pay special attention to:
Commit Message Convention: This PR follows Conventional Commits