Repository navigation
feat(cli): add dimension table list get and create commands - #125
Draft
rtiman-spotify wants to merge 3 commits into
Draft
rtiman-spotify wants to merge 3 commits into
rtiman-spotify wants to merge 3 commits into
Conversation
Co-Authored-By: Xirp Agent (gpt-6.1-sol) <xirp-agent@users.noreply.ghe.spotify.net>
Co-Authored-By: Xirp Agent (gpt-6.1-sol) <xirp-agent@users.noreply.ghe.spotify.net>
Co-Authored-By: Xirp Agent (gpt-6.1-sol) <xirp-agent@users.noreply.ghe.spotify.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds data dimension-tables list/get/create through direct Metrics HTTP APIs. Preserves mappings, supported optional fields, state/errors and schema-validation job references. Supports pagination/filter/order/deleted visibility, bounded --all, resource JSON bodies and optional dimensionTableId.
Dependency
Depends on #122. This fork branch contains the exact shared foundation commits; the main-targeted diff includes them until the foundation lands. Kept draft; do not merge out of order.
Safety
Rejects unknown/output-only fields and new column annotations. Explicit create sends one request; transport/5xx/malformed-success outcomes are reported as unknown with a supplied ID retained for lookup. No automatic retry, immutable-field editing, deletion or replacement.
Verification
Node 24, pnpm build and full pnpm qa passed after current-main auth integration. 211 focused command/input MSW tests pass. Existing E2E regression runs in CI. No live API compatibility claim.
Checklist
Related: https://spotify.atlassian.net/browse/SLMD-1921 and https://spotify.atlassian.net/browse/SLMD-1934.